diff options
| author | Chen Jiahao <[email protected]> | 2023-07-27 11:55:51 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-07-29 01:47:23 +0000 |
| commit | c88c157d25d96ed760b91837aec81f19c44b0bf3 (patch) | |
| tree | 85743c5bd2b2cfde09dcbec5970724b93846eeaf /drivers/net/ethernet/broadcom/asp2/bcmasp.c | |
| parent | bonding: 3ad: Remove unused declaration bond_3ad_update_lacp_active() (diff) | |
| download | kernel-c88c157d25d96ed760b91837aec81f19c44b0bf3.tar.gz kernel-c88c157d25d96ed760b91837aec81f19c44b0bf3.zip | |
net: bcmasp: Clean up redundant dev_err_probe()
Referring to platform_get_irq()'s definition, the return value has
already been checked, error message also been printed via
dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
outside platform_get_irq() is obviously redundant.
Removing dev_err_probe() outside platform_get_irq() to clean up
above problem.
Signed-off-by: Chen Jiahao <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Acked-by: Justin Chen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/broadcom/asp2/bcmasp.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c index a9984efff6d1..eb35ced1c8ba 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1232,7 +1232,7 @@ static int bcmasp_probe(struct platform_device *pdev) priv->irq = platform_get_irq(pdev, 0); if (priv->irq <= 0) - return dev_err_probe(dev, -EINVAL, "invalid interrupt\n"); + return -EINVAL; priv->clk = devm_clk_get_optional_enabled(dev, "sw_asp"); if (IS_ERR(priv->clk)) |