diff options
| author | Emmanuel Gil Peyrot <[email protected]> | 2021-05-11 21:07:24 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2021-05-14 11:45:24 +0000 |
| commit | 4a5ff99bbb8fcd4642995ef39bccc7f25e1f90d3 (patch) | |
| tree | ddfbd67241e11191f101db98fbd0b812da0fd6a3 /drivers/misc/ibmasm/module.c | |
| parent | video: ssd1307fb: Drop OF dependency (diff) | |
| download | kernel-4a5ff99bbb8fcd4642995ef39bccc7f25e1f90d3.tar.gz kernel-4a5ff99bbb8fcd4642995ef39bccc7f25e1f90d3.zip | |
misc: eeprom_93xx46: Remove hardcoded bit lengths
This avoids using magic numbers based on the length of an address or a
command, while we only want to differentiate between 8-bit and 16-bit.
The driver was previously wrapping around the offset in the write
operation, this now returns -EINVAL instead (but should never happen in
the first place).
If two pointer indirections are too many, we could move the flags to the
main struct instead, but I doubt it’s going to make any sensible
difference on any hardware.
Reviewed-by: Jonathan Neuschäfer <[email protected]>
Signed-off-by: Emmanuel Gil Peyrot <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/misc/ibmasm/module.c')
0 files changed, 0 insertions, 0 deletions