diff options
| author | Wen Yang <[email protected]> | 2019-04-03 16:04:13 +0000 |
|---|---|---|
| committer | Eric Anholt <[email protected]> | 2019-04-04 19:56:45 +0000 |
| commit | bc29d3a69d4c1bd1a103e8b3c1ed81b807c1870b (patch) | |
| tree | 73c1226ba5f3f2368c8780ac79dd2b8c50e80ddf /drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | |
| parent | drm/vc4: vc4_debugfs_regset32() can be static (diff) | |
| download | kernel-bc29d3a69d4c1bd1a103e8b3c1ed81b807c1870b.tar.gz kernel-bc29d3a69d4c1bd1a103e8b3c1ed81b807c1870b.zip | |
drm/pl111: fix possible object reference leak
The call to of_find_matching_node_and_match returns a node pointer with
refcount incremented thus it must be explicitly decremented after the
last usage.
Detected by coccinelle with the following warnings:
drivers/gpu/drm/pl111/pl111_versatile.c:333:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function.
drivers/gpu/drm/pl111/pl111_versatile.c:340:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function.
drivers/gpu/drm/pl111/pl111_versatile.c:346:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function.
drivers/gpu/drm/pl111/pl111_versatile.c:354:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function.
drivers/gpu/drm/pl111/pl111_versatile.c:395:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function.
drivers/gpu/drm/pl111/pl111_versatile.c:402:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 317, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <[email protected]>
Cc: Eric Anholt <[email protected]> (supporter:DRM DRIVER FOR ARM PL111 CLCD)
Cc: David Airlie <[email protected]> (maintainer:DRM DRIVERS)
Cc: Daniel Vetter <[email protected]> (maintainer:DRM DRIVERS)
Cc: [email protected] (open list:DRM DRIVERS)
Cc: [email protected] (open list)
Signed-off-by: Eric Anholt <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c')
0 files changed, 0 insertions, 0 deletions