diff options
| author | Thomas Zimmermann <[email protected]> | 2025-03-07 08:36:53 +0000 |
|---|---|---|
| committer | Thomas Zimmermann <[email protected]> | 2025-03-10 09:54:24 +0000 |
| commit | 914ee6e730e134410b77edc453b629767e84c32c (patch) | |
| tree | 5636c1f78750fee229e5221b577cdaa3cc681b98 /drivers/gpu/drm/tiny/appletbdrm.c | |
| parent | Merge tag 'drm-misc-next-2025-03-06' of https://gitlab.freedesktop.org/drm/mi... (diff) | |
| download | kernel-914ee6e730e134410b77edc453b629767e84c32c.tar.gz kernel-914ee6e730e134410b77edc453b629767e84c32c.zip | |
drm/appletbdrm: Fix ref-counting on dmadev
Remove the put_device() call on dmadev. The driver sets the field
without getting a reference, so it shouldn't put a reference either.
The dmadev field points to the regular USB device for which DRM
maintains a reference internally. Hence dmadev will not become dangling
during the DRM device's lifetime.
Signed-off-by: Thomas Zimmermann <[email protected]>
Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
Cc: Aditya Garg <[email protected]>
Cc: Aun-Ali Zaidi <[email protected]>
Cc: [email protected]
Acked-by: Aditya Garg <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/tiny/appletbdrm.c')
| -rw-r--r-- | drivers/gpu/drm/tiny/appletbdrm.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index 394c8f9bd41a..4370ba22dd88 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -805,7 +805,6 @@ static void appletbdrm_disconnect(struct usb_interface *intf) struct appletbdrm_device *adev = usb_get_intfdata(intf); struct drm_device *drm = &adev->drm; - put_device(adev->dmadev); drm_dev_unplug(drm); drm_atomic_helper_shutdown(drm); } |