diff options
| author | Chris Wilson <[email protected]> | 2018-12-30 12:28:42 +0000 |
|---|---|---|
| committer | Chris Wilson <[email protected]> | 2019-01-03 09:54:26 +0000 |
| commit | 227ad6d957898a88b1746e30234ece64d305f066 (patch) | |
| tree | 44c0b042621c52f2627d30c9e24d4d7c3130c747 /drivers/gpu/drm/omapdrm/omap_encoder.c | |
| parent | drm: move DRM_IF_VERSION to drm_internal.h (diff) | |
| download | kernel-227ad6d957898a88b1746e30234ece64d305f066.tar.gz kernel-227ad6d957898a88b1746e30234ece64d305f066.zip | |
drm: Reorder set_property_atomic to avoid returning with an active ww_ctx
Delay the drm_modeset_acquire_init() until after we check for an
allocation failure so that we can return immediately upon error without
having to unwind.
WARNING: lock held when returning to user space!
4.20.0+ #174 Not tainted
------------------------------------------------
syz-executor556/8153 is leaving the kernel with locks still held!
1 lock held by syz-executor556/8153:
#0: 000000005100c85c (crtc_ww_class_acquire){+.+.}, at:
set_property_atomic+0xb3/0x330 drivers/gpu/drm/drm_mode_object.c:462
Reported-by: [email protected]
Fixes: 144a7999d633 ("drm: Handle properties in the core for atomic drivers")
Signed-off-by: Chris Wilson <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: <[email protected]> # v4.14+
Reviewed-by: Maarten Lankhorst <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_encoder.c')
0 files changed, 0 insertions, 0 deletions