diff options
| author | Abhinav Kumar <[email protected]> | 2024-07-31 19:17:22 +0000 |
|---|---|---|
| committer | Abhinav Kumar <[email protected]> | 2024-08-05 20:54:51 +0000 |
| commit | aedf02e46eb549dac8db4821a6b9f0c6bf6e3990 (patch) | |
| tree | 53097dcb786897aff5f65285ff1fe303ec98cc2f /drivers/gpu/drm/msm/dp/dp_ctrl.c | |
| parent | drm/msm/dp: fix the max supported bpp logic (diff) | |
| download | kernel-aedf02e46eb549dac8db4821a6b9f0c6bf6e3990.tar.gz kernel-aedf02e46eb549dac8db4821a6b9f0c6bf6e3990.zip | |
drm/msm/dpu: move dpu_encoder's connector assignment to atomic_enable()
For cases where the crtc's connectors_changed was set without enable/active
getting toggled , there is an atomic_enable() call followed by an
atomic_disable() but without an atomic_mode_set().
This results in a NULL ptr access for the dpu_encoder_get_drm_fmt() call in
the atomic_enable() as the dpu_encoder's connector was cleared in the
atomic_disable() but not re-assigned as there was no atomic_mode_set() call.
Fix the NULL ptr access by moving the assignment for atomic_enable() and also
use drm_atomic_get_new_connector_for_encoder() to get the connector from
the atomic_state.
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Reported-by: Dmitry Baryshkov <[email protected]>
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/59
Suggested-by: Dmitry Baryshkov <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Tested-by: Dmitry Baryshkov <[email protected]> # SM8350-HDK
Patchwork: https://patchwork.freedesktop.org/patch/606729/
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Abhinav Kumar <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/msm/dp/dp_ctrl.c')
0 files changed, 0 insertions, 0 deletions
