diff options
| author | Tom Parkin <[email protected]> | 2020-07-24 15:31:55 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-07-25 00:19:14 +0000 |
| commit | 493048f5dfcd0093880414928717f68613ba9157 (patch) | |
| tree | cde0594b8ee371b19ca93b0a2cf6b3ca9e02ad57 /drivers/gpu/drm/lima/lima_pp.c | |
| parent | l2tp: don't BUG_ON seqfile checks in l2tp_ppp (diff) | |
| download | kernel-493048f5dfcd0093880414928717f68613ba9157.tar.gz kernel-493048f5dfcd0093880414928717f68613ba9157.zip | |
l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge
l2tp_session_queue_purge is used during session shutdown to drop any
skbs queued for reordering purposes according to L2TP dataplane rules.
The BUG_ON in this function checks the session magic feather in an
attempt to catch lifetime bugs.
Rather than crashing the kernel with a BUG_ON, we can simply WARN_ON and
refuse to do anything more -- in the worst case this could result in a
leak. However this is highly unlikely given that the session purge only
occurs from codepaths which have obtained the session by means of a lookup
via. the parent tunnel and which check the session "dead" flag to
protect against shutdown races.
While we're here, have l2tp_session_queue_purge return void rather than
an integer, since neither of the callsites checked the return value.
Signed-off-by: Tom Parkin <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/lima/lima_pp.c')
0 files changed, 0 insertions, 0 deletions