diff options
| author | Pi-Hsun Shih <[email protected]> | 2019-09-04 06:26:13 +0000 |
|---|---|---|
| committer | Enric Balletbo i Serra <[email protected]> | 2019-09-12 14:20:50 +0000 |
| commit | 71cddb7097e2b0feb855d7fd7d59afd12cbee4bb (patch) | |
| tree | 8a3830ff34eceb78811ab73355c38c5c816b2539 /drivers/gpu/drm/lima/lima_gem.c | |
| parent | platform/chrome: chromeos_tbmc: Report wake events (diff) | |
| download | kernel-71cddb7097e2b0feb855d7fd7d59afd12cbee4bb.tar.gz kernel-71cddb7097e2b0feb855d7fd7d59afd12cbee4bb.zip | |
platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed
Since the rpmsg_endpoint is created before probe is called, it's
possible that a host event is received during cros_ec_register, and
there would be some pending work in the host_event_work workqueue while
cros_ec_register is called.
If cros_ec_register fails, when the leftover work in host_event_work
run, the ec_dev from the drvdata of the rpdev could be already set to
NULL, causing kernel crash when trying to run cros_ec_get_next_event.
Fix this by creating the rpmsg_endpoint by ourself, and when
cros_ec_register fails (or on remove), destroy the endpoint first (to
make sure there's no more new calls to cros_ec_rpmsg_callback), and then
cancel all works in the host_event_work workqueue.
Cc: [email protected]
Fixes: 2de89fd98958 ("platform/chrome: cros_ec: Add EC host command support using rpmsg")
Signed-off-by: Pi-Hsun Shih <[email protected]>
Signed-off-by: Enric Balletbo i Serra <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/lima/lima_gem.c')
0 files changed, 0 insertions, 0 deletions