diff options
| author | Lyude Paul <[email protected]> | 2019-01-11 00:53:36 +0000 |
|---|---|---|
| committer | Lyude Paul <[email protected]> | 2019-01-11 01:38:20 +0000 |
| commit | 5e292e7646ef369e6f19c1f83f7795d5eafe3455 (patch) | |
| tree | f87ad3c73cfa0b48d0bd34bdb8936c884f29af36 /drivers/gpu/drm/i915/intel_dp_mst.c | |
| parent | drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() (diff) | |
| download | kernel-5e292e7646ef369e6f19c1f83f7795d5eafe3455.tar.gz kernel-5e292e7646ef369e6f19c1f83f7795d5eafe3455.zip | |
drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
There is no need to look at the port's VCPI allocation before calling
drm_dp_mst_deallocate_vcpi(), as we already have msto->disabled to let
us avoid cleaning up an msto more then once. The DP MST core will never
call drm_dp_mst_deallocate_vcpi() on it's own, which is presumably what
these checks are meant to protect against.
More importantly though, we're about to stop clearing mstc->port in the
next commit, which means if we could potentially hit a use-after-free
error if we tried to check mstc->port->vcpi here. So to make life easier
for anyone who bisects this code in the future, use msto->disabled
instead to check whether or not we need to deallocate VCPI instead.
Signed-off-by: Lyude Paul <[email protected]>
Reviewed-by: Ben Skeggs <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Jerry Zuo <[email protected]>
Cc: Harry Wentland <[email protected]>
Cc: Juston Li <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/i915/intel_dp_mst.c')
0 files changed, 0 insertions, 0 deletions
