diff options
| author | Ville Syrjälä <[email protected]> | 2018-05-25 18:50:45 +0000 |
|---|---|---|
| committer | Ville Syrjälä <[email protected]> | 2018-06-11 17:22:44 +0000 |
| commit | e00fb8564ee98c5c3a72c74b1a27e441abff6cca (patch) | |
| tree | 79c66fa13861f09f232aa77229385a7e0e01e864 /drivers/gpu/drm/drm_framebuffer.c | |
| parent | drm/vc4: Stop updating plane->fb/crtc (diff) | |
| download | kernel-e00fb8564ee98c5c3a72c74b1a27e441abff6cca.tar.gz kernel-e00fb8564ee98c5c3a72c74b1a27e441abff6cca.zip | |
drm: Stop updating plane->crtc/fb/old_fb on atomic drivers
Stop playing around with plane->crtc/fb/old_fb with atomic
drivers. Make life a lot simpler when we don't have to do the
magic old_fb vs. fb dance around plane updates. That way we
can't risk plane->fb getting out of sync with plane->state->fb
and we're less likely to leak any refcounts as well.
Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Maarten Lankhorst <[email protected]>
Acked-by: Harry Wentland <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Sinclair Yeh <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/drm_framebuffer.c')
| -rw-r--r-- | drivers/gpu/drm/drm_framebuffer.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index bfedceff87bb..46b11e46edbd 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -836,8 +836,6 @@ retry: goto unlock; plane_mask |= BIT(drm_plane_index(plane)); - - plane->old_fb = plane->fb; } /* This list is only filled when disable_crtcs is set. */ @@ -852,9 +850,6 @@ retry: ret = drm_atomic_commit(state); unlock: - if (plane_mask) - drm_atomic_clean_old_fb(dev, plane_mask, ret); - if (ret == -EDEADLK) { drm_atomic_state_clear(state); drm_modeset_backoff(&ctx); |