diff options
| author | Aradhya Bhatia <[email protected]> | 2025-06-05 17:15:23 +0000 |
|---|---|---|
| committer | Maxime Ripard <[email protected]> | 2025-06-06 12:24:57 +0000 |
| commit | c9b1150a68d9362a0827609fc0dc1664c0d8bfe1 (patch) | |
| tree | 2adbf2254c393f9704c29f55f954d0af034ea614 /drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | |
| parent | drm/atomic-helper: Separate out bridge pre_enable/post_disable from enable/di... (diff) | |
| download | kernel-c9b1150a68d9362a0827609fc0dc1664c0d8bfe1.tar.gz kernel-c9b1150a68d9362a0827609fc0dc1664c0d8bfe1.zip | |
drm/atomic-helper: Re-order bridge chain pre-enable and post-disable
Move the bridge pre_enable call before crtc enable, and the bridge
post_disable call after the crtc disable.
The sequence of enable after this patch will look like:
bridge[n]_pre_enable
...
bridge[1]_pre_enable
crtc_enable
encoder_enable
bridge[1]_enable
...
bridge[n]_enable
And, the disable sequence for the display pipeline will look like:
bridge[n]_disable
...
bridge[1]_disable
encoder_disable
crtc_disable
bridge[1]_post_disable
...
bridge[n]_post_disable
The definition of bridge pre_enable hook says that,
"The display pipe (i.e. clocks and timing signals) feeding this bridge
will not yet be running when this callback is called".
Since CRTC is also a source feeding the bridge, it should not be enabled
before the bridges in the pipeline are pre_enabled. Fix that by
re-ordering the sequence of bridge pre_enable and bridge post_disable.
While at it, update the drm bridge API documentation as well.
Acked-by: Dmitry Baryshkov <[email protected]>
Reviewed-by: Tomi Valkeinen <[email protected]>
Reviewed-by: Thomas Zimmermann <[email protected]>
Tested-by: Tomi Valkeinen <[email protected]>
Tested-by: Alexander Sverdlin <[email protected]>
Signed-off-by: Aradhya Bhatia <[email protected]>
Signed-off-by: Aradhya Bhatia <[email protected]>
Tested-by: Devarsh Thakkar <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Maxime Ripard <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c')
0 files changed, 0 insertions, 0 deletions
