diff options
| author | Donald Robson <[email protected]> | 2023-12-13 14:44:31 +0000 |
|---|---|---|
| committer | Maxime Ripard <[email protected]> | 2023-12-15 13:04:21 +0000 |
| commit | 8a53e29fe05c56f643eaab285f224c09b9c3dd4c (patch) | |
| tree | 1c544f78b00f29a08567e6c0f6eae7f6621f2d8d /drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | |
| parent | drm/imagination: Fix ERR_PTR test on pointer to pointer. (diff) | |
| download | kernel-8a53e29fe05c56f643eaab285f224c09b9c3dd4c.tar.gz kernel-8a53e29fe05c56f643eaab285f224c09b9c3dd4c.zip | |
drm/imagination: Fix error path in pvr_vm_create_context
It is possible to double free the vm_ctx->mmu_ctx object in this
function.
630 err_page_table_destroy:
--> 631 pvr_mmu_context_destroy(vm_ctx->mmu_ctx);
The pvr_vm_context_put() function does:
kref_put(&vm_ctx->ref_count, pvr_vm_context_release);
Here the pvr_vm_context_release() will call:
pvr_mmu_context_destroy(vm_ctx->mmu_ctx);
Refactor to an unwind style.
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Donald Robson <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c')
0 files changed, 0 insertions, 0 deletions