diff options
| author | Evan Quan <[email protected]> | 2022-04-08 11:51:34 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2022-04-22 18:50:23 +0000 |
| commit | 114f088727314a30b62747bd6f8811dddf535cb6 (patch) | |
| tree | 023b5ca61c1422f1fc266f23b3259582c5a0f768 /drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | |
| parent | drm/amdgpu: add RAS fatal error interrupt handler (diff) | |
| download | kernel-114f088727314a30b62747bd6f8811dddf535cb6.tar.gz kernel-114f088727314a30b62747bd6f8811dddf535cb6.zip | |
drm/amd/pm: fix the deadlock issue observed on SI
The adev->pm.mutx is already held at the beginning of
amdgpu_dpm_compute_clocks/amdgpu_dpm_enable_uvd/amdgpu_dpm_enable_vce.
But on their calling path, amdgpu_display_bandwidth_update will be
called and thus its sub functions amdgpu_dpm_get_sclk/mclk. They
will then try to acquire the same adev->pm.mutex and deadlock will
occur.
By placing amdgpu_display_bandwidth_update outside of adev->pm.mutex
protection(considering logically they do not need such protection) and
restructuring the call flow accordingly, we can eliminate the deadlock
issue. This comes with no real logics change.
Fixes: 3712e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c")
Reported-by: Paul Menzel <[email protected]>
Reported-by: Arthur Marsh <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1957
Signed-off-by: Evan Quan <[email protected]>
Reviewed-by: Lijo Lazar <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c')
0 files changed, 0 insertions, 0 deletions
