diff options
| author | Masami Hiramatsu (Google) <[email protected]> | 2024-10-28 03:26:27 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2024-11-07 22:14:58 +0000 |
| commit | cb6fcef8b4b6c655b6a25cc3a415cd9eb81b3da8 (patch) | |
| tree | 5afa5e4e1aba72214d2ce1d8da03dece6b07e5ef /drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |
| parent | mm/page_alloc: keep track of free highatomic (diff) | |
| download | kernel-cb6fcef8b4b6c655b6a25cc3a415cd9eb81b3da8.tar.gz kernel-cb6fcef8b4b6c655b6a25cc3a415cd9eb81b3da8.zip | |
objpool: fix to make percpu slot allocation more robust
Since gfp & GFP_ATOMIC == GFP_ATOMIC is true for GFP_KERNEL | GFP_HIGH, it
will use kmalloc if user specifies that combination. Here the reason why
combining the __vmalloc_node() and kmalloc_node() is that the vmalloc does
not support all GFP flag, especially GFP_ATOMIC. So we should check if
gfp & (GFP_ATOMIC | GFP_KERNEL) != GFP_ATOMIC for vmalloc first. This
ensures caller can sleep. And for the robustness, even if vmalloc fails,
it should retry with kmalloc to allocate it.
Link: https://lkml.kernel.org/r/173008598713.1262174.2959179484209897252.stgit@mhiramat.roam.corp.google.com
Fixes: aff1871bfc81 ("objpool: fix choosing allocation for percpu slots")
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
Reported-by: Linus Torvalds <[email protected]>
Closes: https://lore.kernel.org/all/CAHk-=whO+vSH+XVRio8byJU8idAWES0SPGVZ7KAVdc4qrV0VUA@mail.gmail.com/
Cc: Leo Yan <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Matt Wu <[email protected]>
Cc: Mikel Rychliski <[email protected]>
Cc: Steven Rostedt (Google) <[email protected]>
Cc: Viktor Malik <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.c')
0 files changed, 0 insertions, 0 deletions