diff options
| author | Bart Van Assche <[email protected]> | 2021-03-20 23:23:53 +0000 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2021-03-25 01:45:06 +0000 |
| commit | 39c0c8553bfb5a3d108aa47f1256076d507605e3 (patch) | |
| tree | 3fceff3017877963948f9b002266ddf257f022ad /drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |
| parent | scsi: ibmvfc: Make ibmvfc_wait_for_ops() MQ aware (diff) | |
| download | kernel-39c0c8553bfb5a3d108aa47f1256076d507605e3.tar.gz kernel-39c0c8553bfb5a3d108aa47f1256076d507605e3.zip | |
scsi: Revert "qla2xxx: Make sure that aborted commands are freed"
Calling vha->hw->tgt.tgt_ops->free_cmd() from qlt_xmit_response() is wrong
since the command for which a response is sent must remain valid until the
SCSI target core calls .release_cmd(). It has been observed that the
following scenario triggers a kernel crash:
- qlt_xmit_response() calls qlt_check_reserve_free_req()
- qlt_check_reserve_free_req() returns -EAGAIN
- qlt_xmit_response() calls vha->hw->tgt.tgt_ops->free_cmd(cmd)
- transport_handle_queue_full() tries to retransmit the response
Fix this crash by reverting the patch that introduced it.
Link: https://lore.kernel.org/r/[email protected]
Fixes: 0dcec41acb85 ("scsi: qla2xxx: Make sure that aborted commands are freed")
Cc: Quinn Tran <[email protected]>
Cc: Mike Christie <[email protected]>
Reviewed-by: Daniel Wagner <[email protected]>
Reviewed-by: Himanshu Madhani <[email protected]>
Signed-off-by: Bart Van Assche <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.c')
0 files changed, 0 insertions, 0 deletions