diff options
| author | Kuan-Wei Chiu <[email protected]> | 2024-12-26 14:03:32 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2024-12-31 01:59:11 +0000 |
| commit | 0210d251162f4033350a94a43f95b1c39ec84a90 (patch) | |
| tree | 4fbb01aa7345b32b027fab1af097fe6a26dcac99 /drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |
| parent | mm/util: make memdup_user_nul() similar to memdup_user() (diff) | |
| download | kernel-0210d251162f4033350a94a43f95b1c39ec84a90.tar.gz kernel-0210d251162f4033350a94a43f95b1c39ec84a90.zip | |
scripts/sorttable: fix orc_sort_cmp() to maintain symmetry and transitivity
The orc_sort_cmp() function, used with qsort(), previously violated the
symmetry and transitivity rules required by the C standard. Specifically,
when both entries are ORC_TYPE_UNDEFINED, it could result in both a < b
and b < a, which breaks the required symmetry and transitivity. This can
lead to undefined behavior and incorrect sorting results, potentially
causing memory corruption in glibc implementations [1].
Symmetry: If x < y, then y > x.
Transitivity: If x < y and y < z, then x < z.
Fix the comparison logic to return 0 when both entries are
ORC_TYPE_UNDEFINED, ensuring compliance with qsort() requirements.
Link: https://www.qualys.com/2024/01/30/qsort.txt [1]
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 57fa18994285 ("scripts/sorttable: Implement build-time ORC unwind table sorting")
Fixes: fb799447ae29 ("x86,objtool: Split UNWIND_HINT_EMPTY in two")
Signed-off-by: Kuan-Wei Chiu <[email protected]>
Cc: Ching-Chun (Jim) Huang <[email protected]>
Cc: <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Shile Zhang <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.c')
0 files changed, 0 insertions, 0 deletions