diff options
| author | Gustavo A. R. Silva <[email protected]> | 2020-10-07 16:08:08 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2020-10-09 18:43:30 +0000 |
| commit | 89c785bb1a7310fa18d0e32af3a6bc9947c348fe (patch) | |
| tree | 1bf3dea926a8cc50c41117b00c4457f7966f5b57 /drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | |
| parent | drm/amd/pm: Replace one-element array with flexible-array in struct phm_cac_l... (diff) | |
| download | kernel-89c785bb1a7310fa18d0e32af3a6bc9947c348fe.tar.gz kernel-89c785bb1a7310fa18d0e32af3a6bc9947c348fe.zip | |
drm/amd/pm: Replace one-element array with flexible-array in struct phm_samu_clock_voltage_dependency_table
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].
Refactor the code according to the use of a flexible-array member in
struct phm_samu_clock_voltage_dependency_table, instead of a one-element array,
and use the struct_size() helper to calculate the size for the allocation.
Also, save some heap space as the original code is multiplying
table->numEntries by sizeof(struct phm_samu_clock_voltage_dependency_table)
when it should have been multiplied it by
sizeof(struct phm_samu_clock_voltage_dependency_record) instead.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays
Build-tested-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/lkml/5f7c5d3a.ryM4GmZr3e0JeZy+%[email protected]/
Acked-by: Christian König <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c')
0 files changed, 0 insertions, 0 deletions
