diff options
| author | Di Zhu <[email protected]> | 2021-06-22 03:09:29 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2021-06-22 17:31:49 +0000 |
| commit | 3c9ef511b9fa128a4c62e3aa0aac4c6b190f0d55 (patch) | |
| tree | 12ac05f9481b4f974e346878a93c6ef92da8c2ac /drivers/fpga/of-fpga-region.c | |
| parent | ip6_tunnel: fix GRE6 segmentation (diff) | |
| download | kernel-3c9ef511b9fa128a4c62e3aa0aac4c6b190f0d55.tar.gz kernel-3c9ef511b9fa128a4c62e3aa0aac4c6b190f0d55.zip | |
bonding: avoid adding slave device with IFF_MASTER flag
The following steps will definitely cause the kernel to crash:
ip link add vrf1 type vrf table 1
modprobe bonding.ko max_bonds=1
echo "+vrf1" >/sys/class/net/bond0/bonding/slaves
rmmod bonding
The root cause is that: When the VRF is added to the slave device,
it will fail, and some cleaning work will be done. because VRF device
has IFF_MASTER flag, cleanup process will not clear the IFF_BONDING flag.
Then, when we unload the bonding module, unregister_netdevice_notifier()
will treat the VRF device as a bond master device and treat netdev_priv()
as struct bonding{} which actually is struct net_vrf{}.
By analyzing the processing logic of bond_enslave(), it seems that
it is not allowed to add the slave device with the IFF_MASTER flag, so
we need to add a code check for this situation.
Signed-off-by: Di Zhu <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/fpga/of-fpga-region.c')
0 files changed, 0 insertions, 0 deletions