diff options
| author | Alexander Popov <[email protected]> | 2020-01-17 22:59:00 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2020-02-17 19:12:19 +0000 |
| commit | 6e317c32fd39a13e4854a27958d5e35d15d196be (patch) | |
| tree | 6c6170fd0ffa3b340c01085761d48be10eb4f5d1 /drivers/clocksource/arm_arch_timer.c | |
| parent | lib/vdso: Allow architectures to provide the vdso data pointer (diff) | |
| download | kernel-6e317c32fd39a13e4854a27958d5e35d15d196be.tar.gz kernel-6e317c32fd39a13e4854a27958d5e35d15d196be.zip | |
timer: Improve the comment describing schedule_timeout()
When working commit 6dcd5d7a7a29c1e, a mistake was noticed by Linus:
schedule_timeout() was called without setting the task state to anything
particular.
It calls the scheduler, but doesn't delay anything, because the task stays
runnable. That happens because sched_submit_work() does nothing for tasks
in TASK_RUNNING state.
That turned out to be the intended behavior. Adding a WARN() is not useful
as the task could be woken up right after setting the state and before
reaching schedule_timeout().
Improve the comment about schedule_timeout() and describe that more
explicitly.
Signed-off-by: Alexander Popov <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/clocksource/arm_arch_timer.c')
0 files changed, 0 insertions, 0 deletions