aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Stevenson <[email protected]>2024-12-09 14:55:45 +0000
committerMauro Carvalho Chehab <[email protected]>2024-12-19 11:50:14 +0000
commitfeaf4154d69657af2bf96e6e66cca794f88b1a61 (patch)
tree26f5ab0547e6c4cb990874d01f53491ccb57c908
parentmedia: intel/ipu6: remove cpu latency qos request on error (diff)
downloadkernel-feaf4154d69657af2bf96e6e66cca794f88b1a61.tar.gz
kernel-feaf4154d69657af2bf96e6e66cca794f88b1a61.zip
media: i2c: ov9282: Correct the exposure offset
The datasheet lists that "Maximum exposure time is frame length -25 row periods, where frame length is set by registers {0x380E, 0x380F}". However this driver had OV9282_EXPOSURE_OFFSET set to 12 which allowed that restriction to be violated, and would result in very under-exposed images. Correct the offset. Fixes: 14ea315bbeb7 ("media: i2c: Add ov9282 camera sensor driver") Signed-off-by: Dave Stevenson <[email protected]> Reviewed-by: Kieran Bingham <[email protected]> Signed-off-by: Sakari Ailus <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
-rw-r--r--drivers/media/i2c/ov9282.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index 9f52af6f047f..87e5d7ce5a47 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -40,7 +40,7 @@
/* Exposure control */
#define OV9282_REG_EXPOSURE 0x3500
#define OV9282_EXPOSURE_MIN 1
-#define OV9282_EXPOSURE_OFFSET 12
+#define OV9282_EXPOSURE_OFFSET 25
#define OV9282_EXPOSURE_STEP 1
#define OV9282_EXPOSURE_DEFAULT 0x0282