diff options
| author | Christophe JAILLET <[email protected]> | 2020-12-13 15:35:13 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2020-12-28 14:14:53 +0000 |
| commit | d887d6104adeb94d1b926936ea21f07367f0ff9f (patch) | |
| tree | d27f820efc633348193ff94481a22344a213373f | |
| parent | Staging: comedi: Return -EFAULT if copy_to_user() fails (diff) | |
| download | kernel-d887d6104adeb94d1b926936ea21f07367f0ff9f.tar.gz kernel-d887d6104adeb94d1b926936ea21f07367f0ff9f.zip | |
staging: mt7621-dma: Fix a resource leak in an error handling path
If an error occurs after calling 'mtk_hsdma_init()', it must be undone by
a corresponding call to 'mtk_hsdma_uninit()' as already done in the
remove function.
Fixes: 0853c7a53eb3 ("staging: mt7621-dma: ralink: add rt2880 dma engine")
Signed-off-by: Christophe JAILLET <[email protected]>
Cc: stable <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/staging/mt7621-dma/mtk-hsdma.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index d241349214e7..bc4bb4374313 100644 --- a/drivers/staging/mt7621-dma/mtk-hsdma.c +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c @@ -712,7 +712,7 @@ static int mtk_hsdma_probe(struct platform_device *pdev) ret = dma_async_device_register(dd); if (ret) { dev_err(&pdev->dev, "failed to register dma device\n"); - return ret; + goto err_uninit_hsdma; } ret = of_dma_controller_register(pdev->dev.of_node, @@ -728,6 +728,8 @@ static int mtk_hsdma_probe(struct platform_device *pdev) err_unregister: dma_async_device_unregister(dd); +err_uninit_hsdma: + mtk_hsdma_uninit(hsdma); return ret; } |