diff options
| author | [email protected] <[email protected]> | 2012-03-22 03:22:38 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2012-03-22 23:32:34 +0000 |
| commit | 5d5440a835710d09f0ef18da5000541ec98b537a (patch) | |
| tree | 3e6e9ed88b266beadbf9698c15852865acb2605a | |
| parent | usbnet: increase URB reference count before usb_unlink_urb (diff) | |
| download | kernel-5d5440a835710d09f0ef18da5000541ec98b537a.tar.gz kernel-5d5440a835710d09f0ef18da5000541ec98b537a.zip | |
usbnet: don't clear urb->dev in tx_complete
URB unlinking is always racing with its completion and tx_complete
may be called before or during running usb_unlink_urb, so tx_complete
must not clear urb->dev since it will be used in unlink path,
otherwise invalid memory accesses or usb device leak may be caused
inside usb_unlink_urb.
Cc: [email protected]
Cc: Alan Stern <[email protected]>
Cc: Oliver Neukum <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Acked-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
| -rw-r--r-- | drivers/net/usb/usbnet.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index febfdceeb9e5..62f8b5cfbb56 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1037,7 +1037,6 @@ static void tx_complete (struct urb *urb) } usb_autopm_put_interface_async(dev->intf); - urb->dev = NULL; entry->state = tx_done; defer_bh(dev, skb, &dev->txq); } |