1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
|
/* t-revokekey.cpp
This file is part of qgpgme, the Qt API binding for gpgme
Copyright (c) 2022 g10 Code GmbH
Software engineering by Ingo Klöcker <[email protected]>
QGpgME is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
published by the Free Software Foundation; either version 2 of the
License, or (at your option) any later version.
QGpgME is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
In addition, as a special exception, the copyright holders give
permission to link the code of this program with any edition of
the Qt library by Trolltech AS, Norway (or with modified versions
of Qt that use the same license as Qt), and distribute linked
combinations including the two. You must obey the GNU General
Public License in all respects for all of the code used other than
Qt. If you modify this file, you may extend this exception to
your version of the file, but you are not obligated to do so. If
you do not wish to do so, delete this exception statement from
your version.
*/
#include "t-support.h"
#include <protocol.h>
#include <revokekeyjob.h>
#include <QDebug>
#include <QProcess>
#include <QRegularExpression>
#include <QSignalSpy>
#include <QTest>
#include <gpgme++/context.h>
#include <gpgme++/data.h>
#include <algorithm>
using namespace QGpgME;
using namespace GpgME;
/* Test keys
sec ed25519 2022-03-29 [SC]
604122B94C86BE846EAFE637FC2BCFB1B19A1CF4
uid [ultimate] [email protected]
ssb cv25519 2022-03-29 [E]
* generated with
export GNUPGHOME=$(mktemp -d)
gpg -K
gpg --batch --pinentry-mode loopback --passphrase abc --quick-gen-key [email protected] default default never
gpg -K
gpg --export-secret-keys --armor --batch --pinentry-mode loopback --passphrase abc --comment [email protected] [email protected] | sed 's/\(.*\)/ "\1\\n"/'
#rm -rf ${GNUPGHOME}
unset GNUPGHOME
*/
static const char *testKeyData =
"-----BEGIN PGP PRIVATE KEY BLOCK-----\n"
"Comment: [email protected]\n"
"\n"
"lIYEYkLSGhYJKwYBBAHaRw8BAQdAWKBjYOZIW33CjwlHKKGIgqXDOGhmbPCStkj1\n"
"+2/cVFL+BwMCXJpRHkD8EcT8DMWdVo84Lx4w7RNDCQx5xnm6rO5kvtmh+PjgM3qt\n"
"CQVGy8H7Dq35yzi0Hihm5zvHxVGYdAu96ShAI2ZqqVL7is0CdAmAibQVcmV2b2tl\n"
"LW1lQGV4YW1wbGUubmV0iJQEExYKADwWIQRgQSK5TIa+hG6v5jf8K8+xsZoc9AUC\n"
"YkLSGgIbAwULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcCF4AACgkQ/CvPsbGaHPSH\n"
"LAD/RNFgm1Bp6ltDXLS6oS0S5Bgjjg3CBpbdxWTvLjPpaagBAIU2pTLrsGNDKIZq\n"
"EAY7hY50tdcvOfT4OSAySJACJzMFnIsEYkLSGhIKKwYBBAGXVQEFAQEHQIOTbPEz\n"
"hUtL72BHfetUWESlEbh2IF/NEUWASUtQJDghAwEIB/4HAwJGE5naBnwwcfyPC+Nq\n"
"DwY5FO28hQVAzgNu9KAncmPtpST1J8sEPAtJGhtq/9fki9eSvBMbAa64VVpFHKHK\n"
"ravZxr2uCrK6J/u4rTvnR8HgiHgEGBYKACAWIQRgQSK5TIa+hG6v5jf8K8+xsZoc\n"
"9AUCYkLSGgIbDAAKCRD8K8+xsZoc9ANAAP9rX/xanm7YvcGFIxPclmy4h33lLaG8\n"
"dE5RA6zeSg7DqQD8Dae82iKaqKfTpe2+2vIEyxBVy8+WttoElUoXiwr0AQg=\n"
"=/5re\n"
"-----END PGP PRIVATE KEY BLOCK-----\n";
class RevokeKeyJobTest : public QGpgMETest
{
Q_OBJECT
private Q_SLOTS:
void initTestCase()
{
QGpgMETest::initTestCase();
// set up the test fixture for this test
qputenv("GNUPGHOME", mGnupgHomeTestFixture.path().toUtf8());
QVERIFY(importSecretKeys(testKeyData, 1));
}
void init()
{
// set up a copy of the test fixture for each test function
mGnupgHomeTestCopy.reset(new QTemporaryDir{});
QVERIFY(copyKeyrings(mGnupgHomeTestFixture.path(), mGnupgHomeTestCopy->path()));
qputenv("GNUPGHOME", mGnupgHomeTestCopy->path().toUtf8());
}
void testAsync()
{
// Get the key that shall be revoked
auto key = getTestKey("[email protected]");
QVERIFY(!key.isNull());
QVERIFY(!key.isRevoked());
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
hookUpPassphraseProvider(job.get());
Error result;
connect(job.get(), &RevokeKeyJob::result,
job.get(), [this, &result](const Error &result_) {
result = result_;
Q_EMIT asyncDone();
});
QVERIFY(!job->start(key, RevocationReason::NoLongerUsed,
{"This key is not used anymore."}));
job.release(); // after the job has been started it's on its own
QSignalSpy spy (this, SIGNAL(asyncDone()));
QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT));
QVERIFY(result.code() == GPG_ERR_NO_ERROR);
key.update();
QVERIFY(key.isRevoked());
verifyReason(key, RevocationReason::NoLongerUsed,
{"This key is not used anymore."});
}
void testSync_noReasonDescription()
{
// Get the key that shall be revoked
auto key = getTestKey("[email protected]");
QVERIFY(!key.isNull());
QVERIFY(!key.isRevoked());
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
hookUpPassphraseProvider(job.get());
const auto result = job->exec(key);
QVERIFY(result.code() == GPG_ERR_NO_ERROR);
key.update();
QVERIFY(key.isRevoked());
verifyReason(key, RevocationReason::Unspecified, {});
}
void testSync_oneLineReasonDescription()
{
// Get the key that shall be revoked
auto key = getTestKey("[email protected]");
QVERIFY(!key.isNull());
QVERIFY(!key.isRevoked());
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
hookUpPassphraseProvider(job.get());
const auto result = job->exec(key, RevocationReason::Compromised,
{"The secret key was stolen."});
QVERIFY(result.code() == GPG_ERR_NO_ERROR);
key.update();
QVERIFY(key.isRevoked());
verifyReason(key, RevocationReason::Compromised,
{"The secret key was stolen."});
}
void testSync_twoLinesReasonDescription()
{
// Get the key that shall be revoked
auto key = getTestKey("[email protected]");
QVERIFY(!key.isNull());
QVERIFY(!key.isRevoked());
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
hookUpPassphraseProvider(job.get());
const auto result = job->exec(key, RevocationReason::Superseded,
{"This key has been superseded by key",
"0000 1111 2222 3333 4444 5555 6666 7777 8888 9999."});
QVERIFY(result.code() == GPG_ERR_NO_ERROR);
key.update();
QVERIFY(key.isRevoked());
verifyReason(key, RevocationReason::Superseded,
{"This key has been superseded by key",
"0000 1111 2222 3333 4444 5555 6666 7777 8888 9999."});
}
void testErrorHandling_nullKey()
{
{
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
QTest::ignoreMessage(QtWarningMsg, "Error: Key is null key");
const auto result = job->exec(Key{});
QVERIFY(result.code() == GPG_ERR_INV_ARG);
}
{
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
QTest::ignoreMessage(QtWarningMsg, "Error: Key is null key");
const auto result = job->start(Key{});
QVERIFY(result.code() == GPG_ERR_INV_ARG);
}
}
void testErrorHandling_invalidReason()
{
// Get the key that shall be revoked
auto key = getTestKey("[email protected]");
QVERIFY(!key.isNull());
QVERIFY(!key.isRevoked());
{
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
QTest::ignoreMessage(QtWarningMsg, QRegularExpression{"^Error: Invalid revocation reason"});
const auto result = job->exec(key, static_cast<RevocationReason>(-1));
QVERIFY(result.code() == GPG_ERR_INV_VALUE);
}
{
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
QTest::ignoreMessage(QtWarningMsg, QRegularExpression{"^Error: Invalid revocation reason"});
const auto result = job->start(key, static_cast<RevocationReason>(4));
QVERIFY(result.code() == GPG_ERR_INV_VALUE);
}
}
void testErrorHandling_invalidDescription()
{
// Get the key that shall be revoked
auto key = getTestKey("[email protected]");
QVERIFY(!key.isNull());
QVERIFY(!key.isRevoked());
{
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
QTest::ignoreMessage(QtWarningMsg, "Error: Revocation description contains empty lines or lines with endline characters");
const auto result = job->exec(key, RevocationReason::Unspecified,
{"line1", "", "line3"});
QVERIFY(result.code() == GPG_ERR_INV_VALUE);
}
{
auto job = std::unique_ptr<RevokeKeyJob>{openpgp()->revokeKeyJob()};
QTest::ignoreMessage(QtWarningMsg, "Error: Revocation description contains empty lines or lines with endline characters");
const auto result = job->start(key, RevocationReason::Unspecified,
{"line1\nline2"});
QVERIFY(result.code() == GPG_ERR_INV_VALUE);
}
}
private:
Key getTestKey(const char *pattern)
{
auto ctx = Context::create(OpenPGP);
VERIFY_OR_OBJECT(ctx);
Error err;
auto key = ctx->key(pattern, err, /*secret=*/true);
VERIFY_OR_OBJECT(!err);
VERIFY_OR_OBJECT(!key.isNull());
return key;
}
bool verifyReason(const Key &key, RevocationReason reason, const QStringList &description)
{
static const auto startTimeout = std::chrono::milliseconds{1000};
static const auto finishTimeout = std::chrono::milliseconds{2000};
static const QStringList hexCodeForReason = {
QStringLiteral("00"), /* no particular reason */
QStringLiteral("02"), /* key has been compromised */
QStringLiteral("01"), /* key is superseded */
QStringLiteral("03") /* key is no longer used */
};
QProcess p;
p.setProgram(dirInfo("gpg-name"));
p.setArguments({QStringLiteral("-K"),
QStringLiteral("--with-colon"),
QStringLiteral("--with-sig-list"),
QLatin1String{key.primaryFingerprint()}
});
p.start();
if (!p.waitForStarted(startTimeout.count())) {
qWarning() << "Timeout while waiting for start of" << p.program() << p.arguments().join(u' ');
return false;
}
if (!p.waitForFinished(finishTimeout.count())) {
qWarning() << "Timeout while waiting for completion of" << p.program() << p.arguments().join(u' ');
return false;
}
if (p.exitStatus() != QProcess::NormalExit) {
qWarning() << p.program() << "terminated abnormally with exit status" << p.exitStatus();
return false;
}
const auto lines = QString::fromUtf8(p.readAllStandardOutput()).split(u'\n');
for (const auto &l : lines) {
const auto fields = l.split(u':');
if (fields[0] == QLatin1String{"rev"}) {
// or "rev" the signature class may be followed by a comma
// and a 2 digit hexnumber with the revocation reason
const auto sigClass = fields.value(10);
const auto revReason = sigClass.split(u',').value(1);
COMPARE_OR_FALSE(revReason, hexCodeForReason.value(static_cast<int>(reason)));
// decode the \n in the C-style quoted comment field
const auto comment = fields.value(20).replace(QStringLiteral("\\n"), QStringLiteral("\n"));
COMPARE_OR_FALSE(comment, description.join(u'\n'));
return true;
}
if (fields[0] == QLatin1String{"uid"}) {
qWarning() << "Found uid before rev in key listing:\n" << stdout;
return false;
}
}
return false;
}
private:
QTemporaryDir mGnupgHomeTestFixture;
std::unique_ptr<QTemporaryDir> mGnupgHomeTestCopy;
};
QTEST_MAIN(RevokeKeyJobTest)
#include "t-revokekey.moc"
|