aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Zelenka <[email protected]>2026-07-14 18:18:26 +0200
committerNikola Pajkovsky <[email protected]>2026-07-20 08:26:03 +0200
commit5eb81718bc4074ca6207c602b00a836e88017b96 (patch)
treeac9e8d7950f8864b78e3a68268f7cd9d377e473f
parentAdd a patch disabling the pem_encoder test (diff)
downloadopenssl-5eb81718bc4074ca6207c602b00a836e88017b96.tar.gz
openssl-5eb81718bc4074ca6207c602b00a836e88017b96.zip
apps: test dsa -text option
The -text option of the dsa app was not exercised by any test. Add a subtest that prints both a private and a public key in text form and, after stripping the colon-separated hex formatting, verifies the printed private and public values match the committed testdsa.pem keypair rather than merely checking that the labels are present. Assisted-by: Claude:claude-opus-4-8 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Daniel Kubec <[email protected]> MergeDate: Mon Jul 20 06:26:08 2026 (Merged from https://github.com/openssl/openssl/pull/31949)
-rw-r--r--test/recipes/15-test_dsa.t45
1 files changed, 44 insertions, 1 deletions
diff --git a/test/recipes/15-test_dsa.t b/test/recipes/15-test_dsa.t
index 2d16ebd02c0..c30cbfbbe33 100644
--- a/test/recipes/15-test_dsa.t
+++ b/test/recipes/15-test_dsa.t
@@ -17,7 +17,7 @@ use OpenSSL::Test::Utils;
setup("test_dsa");
plan skip_all => 'DSA is not supported in this build' if disabled('dsa');
-plan tests => 10;
+plan tests => 11;
require_ok(srctop_file('test','recipes','tconversion.pl'));
@@ -88,6 +88,49 @@ subtest "dsa -modulus prints the DSA public value" => sub {
"-modulus prints the expected public value for a public key");
};
+subtest "dsa -text prints the key in text form" => sub {
+ plan tests => 6;
+
+ # The private (x) and public (y) values of the committed testdsa.pem /
+ # testdsapub.pem keypair. -text prints them as colon-separated hex; we
+ # strip the formatting and compare against the known values so the actual
+ # key material, not just the labels, is verified.
+ my $priv_hex = "BF71D497B89755D0C5E41285D81F9577CC3DF8C2";
+ my $pub_hex = "CC99A07D9817BFF03BB09B183E9B19EB77ABECF192C3A9FBA833DBE"
+ . "69EDB719A8E9777BB82736CEC6A8E4E2FAD0693ACC3D14565D62710B95B02CC"
+ . "6A5CF091EEF9C22F20193EBE114C45A0B5E54A645037E8787FE01B3871508A2"
+ . "5BDBF7C6B81428F89858F133FDB858C390C2EF7BCF7E41D7C66578F792A2488"
+ . "C787EF7C7D41";
+
+ my @priv = run(app(['openssl', 'dsa', '-text', '-noout',
+ '-in', srctop_file("test", "testdsa.pem")],
+ stderr => undef),
+ capture => 1);
+ chomp @priv;
+ my $priv_blob = uc join('', @priv);
+ $priv_blob =~ s/[^0-9A-F]//g;
+ ok(grep(/^Private-Key: \(1024 bit\)$/, @priv),
+ "-text prints the private key header");
+ ok(index($priv_blob, $priv_hex) >= 0,
+ "-text prints the expected private value");
+ ok(index($priv_blob, $pub_hex) >= 0,
+ "-text prints the expected public value for a private key");
+
+ my @pub = run(app(['openssl', 'dsa', '-pubin', '-text', '-noout',
+ '-in', srctop_file("test", "testdsapub.pem")],
+ stderr => undef),
+ capture => 1);
+ chomp @pub;
+ my $pub_blob = uc join('', @pub);
+ $pub_blob =~ s/[^0-9A-F]//g;
+ ok(grep(/^Public-Key: \(1024 bit\)$/, @pub),
+ "-text prints the public key header");
+ ok(index($pub_blob, $pub_hex) >= 0,
+ "-text prints the expected public value for a public key");
+ ok(!grep(/^priv:/, @pub),
+ "-text does not print a private component for a public key");
+};
+
subtest "dsa PVK output is rejected for public key input" => sub {
plan tests => 1;