openssl/test/stack_test.c, branch dependabot/github_actions/actions/setup-python-7

Add stack test for thunked sorted lookup

2026-07-04T16:53:19Z

Reviewed-by: Milan Broz Reviewed-by: Paul Dale Reviewed-by: Frederik Wedel-Heinen Reviewed-by: Neil Horman MergeDate: Sat Jul 4 16:53:24 2026 (Merged from https://github.com/openssl/openssl/pull/30857)

preserve stack thunks across sk_TYPE_dup

2026-06-25T12:12:29Z

ensure typed stack duplicates keep their compare, copy, and free thunks so later operations do not call typed callbacks through erased void * function pointer signatures. Signed-off-by: Nikola Pajkovsky Reviewed-by: Neil Horman Reviewed-by: Milan Broz MergeDate: Thu Jun 25 12:12:48 2026 (Merged from https://github.com/openssl/openssl/pull/31523)

test/stack_test.c: Change structure SS typedef into TST_SS

2026-05-29T07:55:16Z

The original name of the structure SS collides with a define set in a Solaris system header. Reviewed-by: Dmitry Belyavskiy Reviewed-by: Saša Nedvědický Reviewed-by: Eugene Syromiatnikov Reviewed-by: Tomas Mraz MergeDate: Fri May 29 07:56:28 2026 (Merged from https://github.com/openssl/openssl/pull/31224)

stack: use a copy thunk for typed stack deep copies

2026-05-20T15:53:32Z

typed safestack wrappers pass type-specific copy callbacks such as TYPE *(*)(const TYPE *) to OPENSSL_sk_deep_copy(). The generic stack code then called those callbacks through OPENSSL_sk_copyfunc, void *(*)(const void *), which is an incompatible function pointer type and triggers UBSan. Add an OPENSSL_sk_copyfunc_thunk and store it on typed stacks, mirroring the existing compare/free thunk pattern. Generated safestack helpers now install a per-type copy thunk when constructing a stack, and internal_copy() uses that thunk when deep-copying typed stacks. This preserves the generic stack API while ensuring typed copy callbacks are invoked through their real signature. Fixes: https://github.com/openssl/project/issues/1951 Signed-off-by: Nikola Pajkovsky Reviewed-by: Eugene Syromiatnikov Reviewed-by: Neil Horman MergeDate: Wed May 20 15:53:45 2026 (Merged from https://github.com/openssl/openssl/pull/31151)

4.0-POST-CLANG-FORMAT-WEBKIT

2025-12-09T07:28:19Z

Reviewed-by: Saša Nedvědický Reviewed-by: Neil Horman Reviewed-by: Nikola Pajkovsky (Merged from https://github.com/openssl/openssl/pull/29242)

Ensure q variable is freed

2025-09-23T14:34:47Z

Fixes: d88c43a64408 ("Ensure that empty or 1 element stacks are always sorted.") Resolves: https://scan5.scan.coverity.com/#/project-view/65138/10222?selectedIssue=1665465 Signed-off-by: Nikola Pajkovsky Reviewed-by: Matt Caswell Reviewed-by: Kurt Roeckx Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/28596)

Don't clear is_sorted unconditionally on OPENSSL_sk_insert()

2025-09-17T21:30:23Z

If we have a comparison function, and the array was sorted, check to see if we are inserting in the correct location. if so do not clear is_sorted. This allows for element locations found with OPENSSL_sk_find_ex to be used to insert elements in the correct location and preserve the sorting order without the need to sort the stack again. Reviewed-by: Tomas Mraz Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/28533)

Ensure that empty or 1 element stacks are always sorted.

2025-09-17T08:09:39Z

Matt noticed "It's kind of weird that we are forced to call sort on a newly created and empty stack. It feels like an empty stack should have the "sorted" flag by default on creation" I am incluined to agree. This change ensures tht empty or 1 element stacks are marked as sorted, as per the existing comment in the file. Since this involved changing the various duplication routines to also ensure that sorted was preserved for such stacks, I also noticed the duplication code was largely duplicated. I took the opportunity to deduplicate the duplication code while making these changes. Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/28509)

Copyright year updates

2025-09-02T13:05:45Z

Reviewed-by: Neil Horman Reviewed-by: Saša Nedvědický Release: yes

test/stack_test.c: check sk_sint_push result in test_int_stack

2025-08-19T18:47:54Z

coverity complains about possible double free, which does not seem to be the case with the current implementation, but it still would be nice to check and reacto on unexpected sk_sint_push result. Complements: 9837496142cf "Unit tests for crypto/stack." Resolves: https://scan5.scan.coverity.com/#/project-view/65249/10222?selectedIssue=1662046 Related: https://github.com/openssl/project/issues/1317 Signed-off-by: Eugene Syromiatnikov Reviewed-by: Tomas Mraz Reviewed-by: Shane Lontis Reviewed-by: Neil Horman (Merged from https://github.com/openssl/openssl/pull/28238)