openssl/crypto, branch openssl-3.3.2

Copyright year updates

2024-09-03T12:44:27Z

Reviewed-by: Neil Horman Release: yes

Avoid type errors in EAI-related name check logic.

2024-09-03T10:03:11Z

The incorrectly typed data is read only, used in a compare operation, so neither remote code execution, nor memory content disclosure were possible. However, applications performing certificate name checks were vulnerable to denial of service. The GENERAL_TYPE data type is a union, and we must take care to access the correct member, based on `gen->type`, not all the member fields have the same structure, and a segfault is possible if the wrong member field is read. The code in question was lightly refactored with the intent to make it more obviously correct. Fixes CVE-2024-6119 Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit 0890cd13d40fbc98f655f3974f466769caa83680)

Fix error handling in OBJ_add_object

2024-08-21T13:53:57Z

This fixes the possible memory leak in OBJ_add_object when a pre-existing object is replaced by a new one, with identical NID, OID, and/or short/long name. We do not try to delete any orphans, but only mark them as type == -1, because the previously returned pointers from OBJ_nid2obj/OBJ_nid2sn/OBJ_nid2ln may be cached by applications and can thus not be cleaned up before the application terminates. Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/22534) (cherry picked from commit e91384d5b0547bf797e2b44976f142d146c4e650)

Explicitly include e_os.h for close()

2024-08-19T10:27:54Z

Reviewed-by: Tim Hudson Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/25229) (cherry picked from commit 0c0c6954bf4fa7b56e21e1393c9e5e5d55c1b2d6)

RAND_write_file(): Avoid potential file descriptor leak

2024-08-19T09:13:09Z

If fdopen() call fails we need to close the fd. Also return early as this is most likely some fatal error. Fixes #25064 Reviewed-by: Tom Cosgrove Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/25081) (cherry picked from commit d6048344398ec75996fee1f465abb61ab3aa377e)

Fix unpredictible refcount handling of d2i functions

2024-08-16T08:08:59Z

The passed in reference of a ref-counted object is free'd by d2i functions in the error handling. However if it is not the last reference, the in/out reference variable is not set to null here. This makes it impossible for the caller to handle the error correctly, because there are numerous cases where the passed in reference is free'd and set to null, while in other cases, where the passed in reference is not free'd, the reference is left untouched. Therefore the passed in reference must be set to NULL even when it was not the last reference. Fixes #23713 Reviewed-by: Dmitry Belyavskiy Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/22809) (cherry picked from commit d550d2aae531c6fa2e10b1a30d2acdf373663889)

do_print_ex(): Avoid possible integer overflow

2024-08-07T17:39:39Z

Fixes Coverity 1604657 Fixes openssl/project#780 Reviewed-by: Neil Horman Reviewed-by: Tom Cosgrove Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/25084) (cherry picked from commit e3e15e77f14cc4026fd456cc8a2b5190b2d79610)

evp_get_digest/cipherbyname_ex(): Try to fetch if not found

2024-07-31T09:26:10Z

If the name is not found in namemap, we need to try to fetch the algorithm and query the namemap again. Fixes #19338 Reviewed-by: Neil Horman Reviewed-by: Paul Dale Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/24940) (cherry picked from commit 454ca902c7d5337249172b38efc5e4fd63f483f4)

i2d_name_canon(): Check overflow in len accumulation

2024-07-21T16:28:22Z

Fixes Coverity 1604638 Reviewed-by: Neil Horman Reviewed-by: Paul Dale Reviewed-by: Todd Short (Merged from https://github.com/openssl/openssl/pull/24930) (cherry picked from commit b2deefb9d262f0f9eae6964006df98c2fa24daac)

Allow short reads in asn1_d2i_read_bio()

2024-07-18T17:06:20Z

Reviewed-by: Neil Horman Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/22486) (cherry picked from commit 202ef97edc8e5561a6f4db28919d5ed73d411cc7)