openssl/crypto/stack, branch openssl-3.3.1

Copyright year updates

2024-03-20T12:07:54Z

Reviewed-by: Neil Horman Release: yes

Make OPENSSL_sk_push return only 0 or 1

2024-01-04T13:51:48Z

Most of the callers do not actually check for the special -1 return condition because they do not pass NULL to it. It is also extremely improbable that any code depends on this -1 return value in this condition so it can be safely changed to 0 return. Reviewed-by: Matt Caswell Reviewed-by: Ben Kaduk (Merged from https://github.com/openssl/openssl/pull/22930)

Copyright year updates

2023-09-07T08:59:15Z

Reviewed-by: Richard Levitte Release: yes

stack: fix searching when the stack isn't sorted.

2023-04-28T07:24:06Z

More specifically, don't sort the stack when searching when it isn't sorted. This avoids a race condition. Fixes #20135 Reviewed-by: Tim Hudson Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/20782)

Errors raised from OPENSSL_sk_set should have ERR_LIB_CRYPTO

2022-10-21T16:02:35Z

Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400)

stack: Do not add error if pop/shift/value accesses outside of the stack

2022-10-21T16:02:35Z

This partially reverts commit 30eba7f35983a917f1007bce45040c0af3442e42. This is legitimate use of the stack functions and no error should be reported apart from the NULL return value. Fixes #19389 Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400)

Stop raising ERR_R_MALLOC_FAILURE in most places

2022-10-05T12:02:03Z

Since OPENSSL_malloc() and friends report ERR_R_MALLOC_FAILURE, and at least handle the file name and line number they are called from, there's no need to report ERR_R_MALLOC_FAILURE where they are called directly, or when SSLfatal() and RLAYERfatal() is used, the reason `ERR_R_MALLOC_FAILURE` is changed to `ERR_R_CRYPTO_LIB`. There were a number of places where `ERR_R_MALLOC_FAILURE` was reported even though it was a function from a different sub-system that was called. Those places are changed to report ERR_R_{lib}_LIB, where {lib} is the name of that sub-system. Some of them are tricky to get right, as we have a lot of functions that belong in the ASN1 sub-system, and all the `sk_` calls or from the CRYPTO sub-system. Some extra adaptation was necessary where there were custom OPENSSL_malloc() wrappers, and some bugs are fixed alongside these changes. Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/19301)

stack.c: add missing direct error reporting and improve coding style

2022-09-16T08:07:15Z

Doing so, had to fix sloppiness in using the stack API in crypto/conf/conf_def.c, ssl/ssl_ciph.c, ssl/statem/statem_srvr.c, and mostly in test/helpers/ssltestlib.c. Reviewed-by: Tomas Mraz Reviewed-by: Shane Lontis Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18918)

Fix Coverity 1493746: constant expression result

2021-11-16T22:15:35Z

Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/17034)

stack: increase the reallocation ratio

2021-11-12T09:49:46Z

This change increases the reallocation ratio from 1.5 to 1.6. Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/16930)