openssl/crypto/stack/stack.c, branch rsarefTLS/SSL and crypto library.http://git.bktus.com/gpgfrontend/openssl/atom?h=rsaref2000-11-07T13:49:47ZThis commit was manufactured by cvs2svn to create tag 'rsaref'.2000-11-07T13:49:47Zcvs2svncvs2svn2000-11-07T13:49:47Zurn:sha1:9d98df23f38afa21e159d910335b49fb196206e8Some platforms define NULL as ((void *)0). Unfortunately, a void*2000-09-17T14:46:09ZRichard Levittelevitte@openssl.org2000-09-17T14:46:09Zurn:sha1:60dae9985d0120c62552776919ca474266649908
can't be used as a function pointer according the the standards. Use
a 0 instead and there will be no trouble.
Safe stack reorganisation in terms of function casts.2000-06-16T23:29:26ZDr. Stephen Hensonsteve@openssl.org2000-06-16T23:29:26Zurn:sha1:3aceb94b9e6ac4722b96d4fb1cf7e1a4358941e0
After some messing around this seems to work but needs
a few more tests. Working out the syntax for sk_set_cmp_func()
(cast it to a function that itself returns a function pointer)
was painful :-(
Needs some testing to see what other compilers think of this
syntax.
Also needs similar stuff for ASN1_SET_OF etc etc.
Harmonize indentation.2000-06-08T22:41:03ZBodo Möllerbodo@openssl.org2000-06-08T22:41:03Zurn:sha1:3dd985ee2ab05b4eda53b67395d85269acad74bdThere have been a number of complaints from a number of sources that names2000-06-01T22:19:21ZRichard Levittelevitte@openssl.org2000-06-01T22:19:21Zurn:sha1:26a3a48d65c7464b400ec1de439994d7f0d25fed
like Malloc, Realloc and especially Free conflict with already existing names
on some operating systems or other packages. That is reason enough to change
the names of the OpenSSL memory allocation macros to something that has a
better chance of being unique, like prepending them with OPENSSL_.
This change includes all the name changes needed throughout all C files.
This is the first of two commits (didn't want to dump them all into the2000-06-01T02:15:40ZGeoff Thorpegeoff@openssl.org2000-06-01T02:15:40Zurn:sha1:7bb7043580900b8f06cb418b46004b755ff0fc96
same one). However, the first will temporarily break things until the
second comes through. :-)
The safestack.h handling was mapping compare callbacks that externally
are of the type (int (*)(type **,type **)) into the underlying callback
type used by stack.[ch], which is (int (*)(void *,void *)). After some
degree of digging, it appears that the callback type in the underlying
stack code should use double pointers too - when the compare operations
are invoked (from sk_find and sk_sort), they are being used by bsearch
and qsort to compare two pointers to pointers. This change corrects the
prototyping (by only casting to the (void*,void*) form at the moment
it is needed by bsearch and qsort) and makes the mapping in safestack.h
more transparent. It also changes from "void*" to "char*" to stay in
keeping with stack.[ch]'s assumed base type of "char".
Also - the "const" situation was that safestack.h was throwing away
"const"s, and to compound the problem - a close examination of stack.c
showed that (const char **) is not really achieving what it is supposed
to when the callback is being invoked, what is needed is
(const char * const *). So the underlying stack.[ch] and the mapping
macros in safestack.h have all been altered to correct this.
What will follow are the vast quantities of "const" corrections required
in stack-dependant code that was being let "slip" through when
safestack.h was discarding "const"s. These now all come up as compiler
warnings.
sk_value was also suffering from de-const-ification.2000-05-31T17:35:11ZGeoff Thorpegeoff@openssl.org2000-05-31T17:35:11Zurn:sha1:e20d7d71677c6d56f9e486148a0d33cb639765eb
Also, add in a couple of missing declarations in pkcs7 code.
All the little functions created by the IMPLEMENT_STACK_OF() macro will2000-05-31T15:28:01ZGeoff Thorpegeoff@openssl.org2000-05-31T15:28:01Zurn:sha1:01296a6de0f968d741d871efda8ab4ed5420442d
cast their type-specific STACK into a real STACK and call the underlying
sk_*** function. The problem is that if the STACK_OF(..) parameter being
passed in has a "const *" qualifier, it is discarded by the cast.
I'm currently implementing a fix for this but in the mean-time, this is
one case I noticed (a few type-specific sk_**_num() functions pass in
const type-specific stacks). If there are other errors in the code where
consts are being discarded, we will similarly not notice them. yuck.
Get rid of more non-ANSI declarations.2000-05-15T22:54:43ZUlf Möllerulf@openssl.org2000-05-15T22:54:43Zurn:sha1:0e1c06128adbfd2d88dc304db2262140bad045fdispell (and minor modifications)2000-02-03T23:23:24ZUlf Möllerulf@openssl.org2000-02-03T23:23:24Zurn:sha1:657e60fa00ddde3618600d6306be913214d30457