openssl/crypto/core_algorithm.c, branch openssl-3.3.1

Stop raising ERR_R_MALLOC_FAILURE in most places

2022-10-05T12:02:03Z

Since OPENSSL_malloc() and friends report ERR_R_MALLOC_FAILURE, and at least handle the file name and line number they are called from, there's no need to report ERR_R_MALLOC_FAILURE where they are called directly, or when SSLfatal() and RLAYERfatal() is used, the reason `ERR_R_MALLOC_FAILURE` is changed to `ERR_R_CRYPTO_LIB`. There were a number of places where `ERR_R_MALLOC_FAILURE` was reported even though it was a function from a different sub-system that was called. Those places are changed to report ERR_R_{lib}_LIB, where {lib} is the name of that sub-system. Some of them are tricky to get right, as we have a lot of functions that belong in the ASN1 sub-system, and all the `sk_` calls or from the CRYPTO sub-system. Some extra adaptation was necessary where there were custom OPENSSL_malloc() wrappers, and some bugs are fixed alongside these changes. Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/19301)

"Reserve" the method store when constructing methods

2022-07-20T06:28:17Z

Introducing the concept of reserving the store where a number of provided operation methods are to be stored. This avoids racing when constructing provided methods, which is especially pertinent when multiple threads are trying to fetch the same method, or even any implementation for the same given operation type. This introduces a |biglock| in OSSL_METHOD_STORE, which is separate from the |lock| which is used for more internal and finer grained locking. Fixes #18152 Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/18153)

Refactor method construction pre- and post-condition

2022-05-05T13:05:54Z

The existing pre- and post-condition functions are supposed to check if methods have already been created and stored, using provider operation bits. This is supposed to only be done for "permanent" method stores. However, the way the pre-condition was called, it could not know if the set of implementations to be stored is likely to end up in a "permanent" or a temporary store. It needs access to the |no_store| flag returned by the provider's operation query function, because that call was done after the pre-condition was called. This requires a bit of refactoring, primarly of |algorithm_do_this()|, but also of |ossl_method_construct_precondition()|. Fixes #18150 Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18151)

CORE: add a provider argument to ossl_method_construct()

2021-10-27T10:41:10Z

This makes it possible to limit the search of methods to that particular provider. This uses already available possibilities in ossl_algorithm_do_all(). Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/16725)

Fix pointer passed to provider_unquery_operation

2021-05-17T00:22:27Z

Walking through the `map` modifies the pointer passed to the `unquery` operation. Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/15295)

Add type_name member to provided methods and use it

2021-04-26T10:05:05Z

Fixes #14701 Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/14898)

rename ossl_provider_forall_loaded to ossl_provider_doall_activated

2021-03-11T23:14:00Z

Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/14489)

Update copyright year

2021-03-11T13:27:36Z

Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/14512)

provider: add an unquery function to allow providers to clean up.

2021-02-24T11:24:36Z

Without this, a provider has no way to know that an application has finished with the array it returned earlier. A non-caching provider requires this information. Fixes #12974 Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/12974)

Rename OPENSSL_CTX prefix to OSSL_LIB_CTX

2020-10-15T10:59:53Z

Many of the new types introduced by OpenSSL 3.0 have an OSSL_ prefix, e.g., OSSL_CALLBACK, OSSL_PARAM, OSSL_ALGORITHM, OSSL_SERIALIZER. The OPENSSL_CTX type stands out a little by using a different prefix. For consistency reasons, this type is renamed to OSSL_LIB_CTX. Reviewed-by: Paul Dale Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/12621)