openssl/apps, branch OpenSSL_1_0_1s

CVE-2016-0798: avoid memory leak in SRP

2016-02-25T14:44:21Z

The SRP user database lookup method SRP_VBASE_get_by_user had confusing memory management semantics; the returned pointer was sometimes newly allocated, and sometimes owned by the callee. The calling code has no way of distinguishing these two cases. Specifically, SRP servers that configure a secret seed to hide valid login information are vulnerable to a memory leak: an attacker connecting with an invalid username can cause a memory leak of around 300 bytes per connection. Servers that do not configure SRP, or configure SRP but do not configure a seed are not vulnerable. In Apache, the seed directive is known as SSLSRPUnknownUserSeed. To mitigate the memory leak, the seed handling in SRP_VBASE_get_by_user is now disabled even if the user has configured a seed. Applications are advised to migrate to SRP_VBASE_get1_by_user. However, note that OpenSSL makes no strong guarantees about the indistinguishability of valid and invalid logins. In particular, computations are currently not carried out in constant time. Reviewed-by: Rich Salz

To avoid possible time_t overflow use X509_time_adj_ex()

2016-01-14T03:04:31Z

Reviewed-by: Viktor Dukhovni (cherry picked from commit 9aa00b187a65b1f30789d6274ec31ea86efe7973) Conflicts: apps/x509.c

Fix X509_STORE_CTX_cleanup()

2016-01-05T02:50:01Z

Reviewed-by: Dr. Stephen Henson

Remove the "eay" c-file-style indicators

2015-12-18T12:13:31Z

Since we don't use the eay style any more, there's no point tryint to tell emacs to use it. Reviewed-by: Ben Laurie

Fix missing malloc return value checks

2015-11-09T23:00:37Z

During work on a larger change in master a number of locations were identified where return value checks were missing. This backports the relevant fixes. Reviewed-by: Richard Levitte (cherry picked from commit 903738ac63e60c10552741e2d6de9753c67e0ff3) Conflicts: crypto/cms/cms_sd.c

Remove useless code

2015-10-23T18:47:53Z

RT#4081 Reviewed-by: Rich Salz Reviewed-by: Richard Levitte (cherry picked from commit 070c23325af4526c9a8532a60d63522c58d5554b)

Do not treat 0 return value from BIO_get_fd() as error

2015-10-23T18:38:06Z

0 is a valid file descriptor. RT#4068 Reviewed-by: Rich Salz Reviewed-by: Richard Levitte (cherry picked from commit 4428c7dba8f6f407d915c1226f4e0f673e8be241)

Don't try and parse boolean type.

2015-10-06T14:16:50Z

Reviewed-by: Rich Salz (cherry picked from commit e58c4d3cdde7a0a01df2884bfeec31a2b07be22d)

SRP memory leak fix

2015-09-28T13:34:47Z

Reviewed-by: Richard Levitte (cherry picked from commit 92ea6fe597238779e23fd9e1fee82d30641d61a8)

Make SRP work with -www

2015-09-20T13:28:22Z

PR#3817 Reviewed-by: Rich Salz (cherry picked from commit 4e7e623012e1604d985e2ef362c2957d464f3f01) Conflicts: apps/s_server.c