openssl/apps/dhparam.c, branch OpenSSL_1_1_1e

apps/dsaparam.c generates code that is intended to be pasted or included

2018-07-29T21:34:32Z

into an existing source file: the function is static, and the code doesn't include dsa.h. Match the generated C source style of dsaparam. Adjust apps/dhparam.c to match, and rename the BIGNUMs to their more usual single-letter names. Add an error return in the generated C source. both: simplify the callback function Signed-off-by: Beat Bolli Reviewed-by: Rich Salz Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/6797)

Fix late opening of output file

2018-04-23T08:51:36Z

For 'openssl dhparams', the output file was opened after calculations were made, which is a waste of cycles and time if the output file turns out not to be writable. Fixes #3404 Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/6051)

Update copyright year

2018-02-13T13:59:25Z

Reviewed-by: Richard Levitte

apps: Don't include progs.h in apps.h

2018-01-31T22:45:12Z

Everything in apps includes apps.h, because that one declares apps internal library routines. However, progs.h doesn't declare library routines, but rather the main commands and their options, and there's no reason why the library modules should include it. So, remove the inclusion of progs.h from apps.h and add that inclusion in all command source files. Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/5222)

Consistent formatting for sizeof(foo)

2017-12-08T00:11:49Z

Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/4872)

Remove parentheses of return.

2017-10-18T15:05:06Z

Since return is inconsistent, I removed unnecessary parentheses and unified them. Reviewed-by: Rich Salz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/4541)

Standardize apps use of -rand, etc.

2017-07-16T23:20:45Z

Standardized the -rand flag and added a new one: -rand file... Always reads the specified files -writerand file Always writes to the file on exit For apps that use a config file, the RANDFILE config parameter reads the file at startup (to seed the RNG) and write to it on exit if the -writerand flag isn't used. Ensured that every app that took -rand also took -writerand, and made sure all of that agreed with all the documentation. Fix error reporting in write_file and -rand Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/3862)

Clean up a bundle of codingstyle stuff in apps directory

2017-06-12T20:11:05Z

Mostly braces and NULL pointer check and also copyright year bump Signed-off-by: Paul Yang Reviewed-by: Kurt Roeckx Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/3657)

Ensure dhparams can handle X9.42 params in DER

2017-04-03T19:04:06Z

dhparams correctly handles X9.42 params in PEM format. However it failed to correctly processes them when reading/writing DER format. Fixes #3102 Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/3111)

If an engine comes up explicitely, it must also come down explicitely

2016-10-19T15:44:08Z

In apps/apps.c, one can set up an engine with setup_engine(). However, we freed the structural reference immediately, which means that for engines that don't already have a structural reference somewhere else (because it's a built in engine), we end up returning an invalid reference. Instead, the function release_engine() is added, and called at the end of the routines that call setup_engine(). Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/1643)