openssl/apps/apps.c, branch OpenSSL_1_0_2s

Update copyright year

2018-08-14T12:40:34Z

Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/6955)

apps: when the 'compat' nameopt has been set, leave it be

2018-05-31T09:02:21Z

XN_FLAG_COMPAT has a unique property, its zero for value. This means it needs special treatment; if it has been set (which can only be determined indirectly) and set alone (*), no other flags should be set. (*) if any other nameopt flag has been set by the user, compatibility mode is blown away. Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/6382) (cherry picked from commit 3190d1dca43ecfd748c06aa06752de06af3768b9)

Standardize syntax around sizeof(foo)

2017-12-08T20:08:43Z

Reviewed-by: Andy Polyakov (Merged from https://github.com/openssl/openssl/pull/4875)

Resolve warnings in VC-WIN32 build, which allows to add /WX.

2017-11-13T10:16:52Z

It's argued that /WX allows to keep better focus on new code, which motivates its comeback... Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/4718)

apps: make setup_engine() and release_engine() available always

2016-10-20T07:04:00Z

This removes some #ifndef clutter. Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/1644)

If an engine comes up explicitely, it must also come down explicitely

2016-10-20T07:04:00Z

In apps/apps.c, one can set up an engine with setup_engine(). However, we freed the structural reference immediately, which means that for engines that don't already have a structural reference somewhere else (because it has registered at least one cipher or digest algorithm method, and therefore gets a functional reference through the ENGINE_set_default() call), we end up returning an invalid reference. Instead, the function release_engine() is added, and called at the end of the routines that call setup_engine(). Originally, the ENGINE API wasn't designed for this to happen, an engine had to register at least one algorithm method, and was especially expected to register the algorithms corresponding to the key types that could be stored and hidden in hardware. However, it turns out that some engines will not register those algorithms with the ENGINE_set_{algo}, ENGINE_set_cipher or ENGINE_set_digest functions, as they only want the methods to be used for keys, not as general crypto accelerator methods. That may cause ENGINE_set_default() to do nothing, and no functional reference is therefore made, leading to a premature deallocation of the engine and it thereby becoming unavailable when trying to fetch a key. Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/1644)

apps/apps.c: initialize and de-initialize engine around key loading

2016-09-28T20:00:26Z

Before loading a key from an engine, it may need to be initialized. When done loading the key, we must de-initialize the engine. (if the engine is already initialized somehow, only the reference counter will be incremented then decremented) Reviewed-by: Stephen Henson (cherry picked from commit 49e476a5382602d0bad1139d6f1f66ddbc7959d6)

Revert "Call ENGINE_init() before trying to use keys from engine"

2016-09-28T18:39:32Z

This reverts commit 4badd2b3c29c2c6c551c737c07a429a53d9d1a0d. This fails to call ENGINE_finish; an alternate fix is coming. Reviewed-by: Dr. Stephen Henson

Call ENGINE_init() before trying to use keys from engine

2016-09-28T13:34:20Z

Things like 'openssl s_client' only ever worked with keys from an engine which provided a default generic method for some key type — because it called ENGINE_set_default() and that ended up being an implicit initialisation and functional refcount. But an engine which doesn't provide generic methods doesn't get initialised, and then when you try to use it you get an error: cannot load client certificate private key file from engine 140688147056384:error:26096075:engine routines:ENGINE_load_private_key:not initialised:crypto/engine/eng_pkey.c:66: unable to load client certificate private key file cf. https://github.com/OpenSC/libp11/issues/107 (in which we discover that engine_pkcs11 *used* to provide generic methods that OpenSSL would try to use for ephemeral DH keys when negotiating ECDHE cipher suites in TLS, and that didn't work out very well.) Reviewed-by: Richard Levitte Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/1640)

apps/apps.c: include sys/socket.h to declare recv()

2016-09-21T14:21:08Z

Reviewed-by: Tim Hudson (cherry picked from commit a19228b7f4fc6fcb49713455b3caedbc24fb0b01)