2003-05-27 Marcus Brinkmann <[email protected]>

	* encrypt.c (gpgme_op_encrypt_result): Use intermediate variable
	HOOK to avoid compiler warning.  Don't ask, you don't want to know.
	(_gpgme_encrypt_status_handler): Likewise.
	(_gpgme_op_encrypt_init_result): Likewise.
	* decrypt.c (gpgme_op_decrypt_result): Likewise.
	(_gpgme_decrypt_status_handler): Likewise.
	(_gpgme_op_decrypt_init_result): Likewise.
	* verify.c (gpgme_op_verify_result): Likewise.
	(_gpgme_verify_status_handler): Likewise.
	(_gpgme_op_verify_init_result): Likewise.
	* edit.c (edit_status_handler): Likewise.
	(command_handler): Likewise.
	(edit_start): Likewise.
	* genkey.c (gpgme_op_genkey_result): Likewise.
	(genkey_status_handler): Likewise.
	(genkey_start): Likewise.
	* import.c (gpgme_op_import_result): Likewise.
	(import_status_handler): Likewise.
	(_gpgme_op_import_start): Likewise.
	* trustlist.c (gpgme_op_trustlist_next): Likewise.
	(_gpgme_op_trustlist_event_cb): Likewise.
	(gpgme_op_trustlist_start): Likewise.
	* keylist.c (gpgme_op_keylist_result): Likewise.
	(keylist_colon_handler): Likewise.
	(keylist_status_handler): Likewise.
	(_gpgme_op_keylist_event_cb): Likewise.
	(gpgme_op_keylist_start): Likewise.
	(gpgme_op_keylist_ext_start): Likewise.
	(gpgme_op_keylist_next): Likewise.
	* passphrase.c (_gpgme_passphrase_status_handler): Likewise.
	(_gpgme_passphrase_command_handler_internal): Likewise.
	* sign.c (gpgme_op_sign_result): Likewise.
	(_gpgme_sign_status_handler): Likewise.
	(_gpgme_op_sign_init_result): Likewise.

1 files changed, 24 insertions, 8 deletions

diff --git a/gpgme/edit.c b/gpgme/edit.c
index 7df5f939..023bbe07 100644
--- a/gpgme/edit.c
+++ b/gpgme/edit.c
@@ -39,12 +39,24 @@ static gpgme_error_t
 edit_status_handler (void *priv, gpgme_status_code_t status, char *args)
 {
   gpgme_ctx_t ctx = (gpgme_ctx_t) priv;
+  gpgme_error_t err;
+  void *hook;
   op_data_t opd;
 
-  return _gpgme_passphrase_status_handler (priv, status, args)
-    || _gpgme_progress_status_handler (priv, status, args)
-    || _gpgme_op_data_lookup (ctx, OPDATA_EDIT, (void **) &opd, -1, NULL)
-    || (*opd->fnc) (opd->fnc_value, status, args, -1);
+  err = _gpgme_passphrase_status_handler (priv, status, args);
+  if (err)
+    return err;
+
+  err = _gpgme_progress_status_handler (priv, status, args);
+  if (err)
+    return err;
+
+  err = _gpgme_op_data_lookup (ctx, OPDATA_EDIT, &hook, -1, NULL);
+  opd = hook;
+  if (err)
+    return err;
+
+  return (*opd->fnc) (opd->fnc_value, status, args, -1);
 }
 
 
@@ -54,7 +66,6 @@ command_handler (void *priv, gpgme_status_code_t status, const char *args,
 {
   gpgme_ctx_t ctx = (gpgme_ctx_t) priv;
   gpgme_error_t err;
-  op_data_t opd;
   int processed = 0;
 
   if (ctx->passphrase_cb)
@@ -67,7 +78,11 @@ command_handler (void *priv, gpgme_status_code_t status, const char *args,
 
   if (!processed)
     {
-      err = _gpgme_op_data_lookup (ctx, OPDATA_EDIT, (void **) &opd, -1, NULL);
+      void *hook;
+      op_data_t opd;
+
+      err = _gpgme_op_data_lookup (ctx, OPDATA_EDIT, &hook, -1, NULL);
+      opd = hook;
       if (err)
 	return err;
 
@@ -82,6 +97,7 @@ edit_start (gpgme_ctx_t ctx, int synchronous, gpgme_key_t key,
 	    gpgme_edit_cb_t fnc, void *fnc_value, gpgme_data_t out)
 {
   gpgme_error_t err;
+  void *hook;
   op_data_t opd;
 
   err = _gpgme_op_reset (ctx, synchronous);
@@ -91,8 +107,8 @@ edit_start (gpgme_ctx_t ctx, int synchronous, gpgme_key_t key,
   if (!fnc || !out)
     return GPGME_Invalid_Value;
 
-  err = _gpgme_op_data_lookup (ctx, OPDATA_EDIT, (void **) &opd,
-			       sizeof (*opd), NULL);
+  err = _gpgme_op_data_lookup (ctx, OPDATA_EDIT, &hook, sizeof (*opd), NULL);
+  opd = hook;
   if (err)
     return err;