gpgme/src, branch dkg/fix-T4276

core: Fix duplication of close_notify_handler for gpgsm.

2019-04-19T05:54:52Z

* src/engine-gpgsm.c [!USE_DESCRIPTOR_PASSING] (gpgsm_new): Remove last call to _gpgme_io_set_close_notify. -- It is called just after the code in question for all cases. GnuPG-bug-id: 4456 Fixes-commit: dd21ec997cf4b6ba18538c63c728478110ad1f60 Signed-off-by: NIIBE Yutaka

core: Fix error return.

2019-04-19T02:34:12Z

* src/engine.c (_gpgme_set_engine_info): Add error return. Signed-off-by: NIIBE Yutaka

core,w32: Fix minor potential memleak

2019-04-09T12:24:17Z

* src/w32-util.c (_gpgme_create_process_utf8): Free converted startup info strings.

core,w32: Fix new w32-util functions

2019-04-09T12:11:21Z

* src/w32-util.c (_gpgme_access): Respect mode parameter. (_gpgme_create_process_utf8): Convert startupinfo, too. -- This both did not show up in testing as we only use mode F_OK and STARTUPINFOA is basically the same as STARTUPINFOW. Fixes commit: a82e3a0ae57a48ba173e282a050680751006c074 GnuPG-Bug-Id: T4453

core,w32: Improve handling of Unicode paths

2019-04-09T11:42:58Z

* src/dirinfo.c (get_gpgconf_item): Use _gpgme_access. * src/posix-util.c (_gpgme_access): Add forward to normal access. * src/sys-util.h (_gpgme_access): New for posix and w32. * src/w32-io.c (_gpgme_io_spawn): Use _gpgme_crate_process_utf8. * src/w32-util.c (utf8_to_wchar, utf8_to_wchar0): The usual w32 conv. (find_program_in_dir): Use _gpgme_access. (find_program_at_standard_place): Use wchar API and convert to UTF-8. (_gpgme_access): Convert UTF-8 to wchar and use wchar API. (_gpgme_create_process_utf8): Convert UTF-8 to wchar and use wchar API. -- While we should not say that we have full support for unicode path installations of GnuPG, this ensures that GPGME works if GPGME itself is installed in a unicode path. e.g.: Libreoffice supports this. GnuPG-Bug-Id: T4453 Based on a patch provided by Egor Pugin. Thanks.

core,w32: Show w32-spawn warning only once

2019-04-09T11:25:08Z

* src/w32-io.c (_gpgme_io_spawn): Show MessageBox only once. -- This prevents multiple message boxes from showing when the GPGME installation is unworkable. GnuPG-Bug-Id: T4453

core, w32: Fix format string errors on windows

2019-03-27T16:47:41Z

* src/debug.c (_gpgme_debug): Use gpgrt_vasprintf instead of vfprintf to have a more portable format. -- This fixes crashes on Windows because "%zu" is used which is not natively supported on Windows but which gpgrt supports.

core: Fix assuan logger-fd hack for windows

2019-03-27T15:12:38Z

* src/assuan-support.c (my_spawn): Zero is a perfectly fine fd.

core,w32,glib: Fix build of w32-glib-io.c

2019-03-26T18:22:44Z

* src/w32-glib-io.c (_gpgme_io_pipe, _gpgme_io_connect): Do not use TRACE_SUC in a return statement.

core: Fix a strtoul to strtol

2019-03-26T15:35:13Z

* src/assuan-support.c (my_spawn): Fix using strtoul for a long. -- This was commented on in129def87b262 and is correct. It is signed here to better handle cases where an invalid handle value (-1) would be passed.