gpgme/src, branch dkg/fix-4820

gpg: Send --with-keygrip when listing keys

2020-01-23T22:57:54Z

* src/engine-gpg.c (gpg_keylist_build_options): Always pass --with-keygrip when listing keys. -- Some older versions of GnuPG (at least gpg in version 2.2.12-1+deb10u1) appear to unilaterally emit the keygrip, and it's certainly useful to know that programmatically it will always be present in the output needed. However, as of GnuPG 2.2.19-1, the following command does not emit the keygrip for non-secret keys: gpg --with-colons --with-secret --list-keys This change fixes tests/json/t-json by making the output comply with tests/json/t-keylist-secret.out.json correctly. Signed-off-by: Daniel Kahn Gillmor GnuPG-Bug-Id: 4820

core: Add MacOS fallbacks to look for binaries

2020-01-17T11:42:56Z

* src/posix-util.c (find_executable): New. (walk_path_str): Factored out from walk_path. (walk_path): Replaced by find_executable. (_gpgme_get_gpg_path, _gpgme_get_gpgconf_path): Use find_executable. -- This should help to locate GnuPG on MacOS systems where it is not part of the PATH environment variable and should reduce the need to have fixed path known at GPGME compile time. mailvelope/issue699

core: Extend gpgme_user_id_t with uidhash member.

2019-12-13T14:11:00Z

* src/gpgme.h.in (struct _gpgme_user_id): Add field 'uidhash'. * src/key.c (gpgme_key_unref): Free it. * src/keylist.c (keylist_colon_handler): Set it. * tests/run-keylist.c (main): Print it. -- The uidhash value is part of gpg's output since the year 2005. This now adds support to gpgme. The application for uidhash is to select a user id in an edit interactor: Instead of giving the number of the user id, the uidhash value can be be used to avoid tracking the user id numbers. Signed-off-by: Werner Koch

gpg: Avoid error diagnostics with --override-session-key when verifying

2019-12-06T01:41:44Z

* src/engine-gpg.c (gpg_decrypt): only send --no-keyring when we are not verifying. -- Without this change, the signature verification would fail. This problem was introduced in bded8ebc59c7fdad2617f4c9232a58047656834c in an attempt to avoid an error when *not* verifying. Clearly more test suite coverage is needed to avoid introducing this sort of problem in the future. GnuPG-bug-id: 3464 Signed-off-by: Daniel Kahn Gillmor

gpgme-tool: Fix help text for INCLUDE_CERTS.

2019-12-03T23:42:07Z

* src/gpgme-tool.c (hlp_include_certs): added missing newline. Signed-off-by: Daniel Kahn Gillmor

core,w32: Silence compiler warnings.

2019-11-27T19:40:39Z

* src/w32-util.c (_gpgme_w32_cancel_synchronous_io): Add some casts. -- Signed-off-by: Werner Koch

core: Fix parsing of userid sigs after a subpkg

2019-10-29T15:43:37Z

* src/keylist.c (keylist_colon_handler): Do not clear out the tmp_uid when a subpacket line is encountered. -- When the uid is cleared no more signatures following the subpacket are parsed, so we now no longer clear it when a subpacket is encountered.

core: Add cert-notation support and extended-edit

2019-10-29T15:11:54Z

* src/context.h (gpgme_context): Add new flag for extended-edit. * src/engine-gpg.c (append_args_from_sig_notations): Add flags to control the kind of notations. (gpg_edit): Respect extended-edit and notations. (gpg_encrypt_sign, gpg_sign): Update call to append_args_from_sig_notations. * src/gpgme.c (gpgme_set_ctx_flag, gpgme_get_ctx_flag): Support extended-edit. * NEWS, doc/gpgme.texi: Mention extended-edit. -- This provides a way to get the extended key-edit interface without breaking bad state machines that rely on the current command flow. A use case for this is to enable multiple local signatures, which can be used together with annotations for: GnuPG-Bug-Id: T4734

core,w32: Initialize dbg_help for socket debugging

2019-10-28T15:02:22Z

* src/w32-io.c (_gpgme_io_select): Initialize dbg_help. -- This fixes a crash on Windows because dbg_help might be used unitialized.

core: Fix arg counting in enginge-gpg

2019-07-16T09:39:29Z

* src/engine-gpg.c (build_argv): Properly check for all arguments and allocate memory for them. -- This fixes a potential buffer overflow which could be created by using unusual and partially contradictory options. Like offline and auto-key-locate together while using ignore-mdc-error. As the list of arguments should not be user controlled the impact of this is very low. To ensure that this does not happen in the future an assert is also added with this patch.