gpgme/src, branch ben/estreams-fix

python bindings: estreams fix

2018-08-30T05:41:31Z

* lang/python/src/core.py: Adjusted new_from_estream function to alias new_from_stream instead of fd. * fixed the _gpgme import errors introduced in commit 08cd34afb762975b0273575035dacf69449ef241 by changing the exported functions/types to match the inner module where all the work is done, rather than the outer one(s). Tested-by: Ben McGinnes Signed-off-by: Ben McGinnes

json: Fix detached verify

2018-08-29T12:32:36Z

* src/gpgme-json.c (op_verify): Only create output and use it for clearsigned and opaque signed. -- Just passing output to gpgme_op_verify changes the behavior to no longer do a verify of the signature.

json: Delete primary key if subkey gen fails

2018-08-28T06:35:06Z

* src/gpgme-json.c (op_delete): Delete primary key on subkey gen error. -- This can happen for example if the user cancels the pinentry to unlock the primary key when adding the subkey. To avoid an artifact of a pimary key without an encryption capable subkey we delete the created key and treat the whole operation as failed.

json: Allow NULL request in encode and chunk

2018-08-28T06:05:46Z

* src/gpgme-json.c (encode_and_chunk): Don't error on NULL request. -- This fixes the error that is passed when parthing the json object failed and request would be NULL. Instead of the JSON parser error it would otherwise report that encode and chunk failed.

json: Do not put FILE_NAME into the verify result.

2018-08-27T09:43:02Z

* src/gpgme-json.c (verify_result_to_json): Remove "file_name". -- Having the file name in the verify result may lead developers to assume that the file name is covered by the signature. This is not the case and can easily be checked by hex-editing a signed message. We better don't output it at all. The same is true for the is_mime flag but that is anyway only an advisory and I can't see damage from a faulty one. Note that we keep file_name in gpgme's output for ABI stability and because some tools want to display meta information even if they are subject to tampering. This is similar to the non-encrypted subject in mails. Signed-off-by: Werner Koch

doc: Add warning that FILE_NAME is not part of the signed data.

2018-08-27T09:43:02Z

core: Export gpgme_data_new_from_estream function.

2018-08-27T07:06:20Z

Signed-off-by: Werner Koch

json: Add sender and file name to encrypt

2018-08-23T18:50:18Z

* src/gpgme-json.c (hlp_encrypt, op_encrypt): Support sender and file_name.

json: Add proper decrypt_result_t handling

2018-08-21T12:36:42Z

* src/gpgme-json.c (recipient_to_json, decrypt_result_to_json): New. (op_decrypt, hlp_decrypt): Update. -- The op_decrypt as one of the first operations did not yet match the current 1 <> 1 mapping of gpgme types to json dictonaries. info and dec_info are bad names but used for compatibility reasons.

json: Add subkey_algo and defaults to createkey

2018-08-20T14:38:36Z

* src/gpgme-json.c (op_createkey, hlp_createkey): Add subkey_algo handling. (hlp_createkey): Fix documentation of expiry. -- Due to the funny quick-gen-key interface generating a key with an explicit algo would result in bad defaults (only an SC key), without a subkey. This adds handling that should probably be in GnuPG proper to fix the semantics of createkey by adding default subkey_algo handling.