gpgme/src/w32-io.c, branch gpgme-1.7.1

core: Remove (now) useless diagnostic

2016-08-18T15:14:36Z

* src/w32-io.c(_gpgme_io_spawn): Remove spawnhelper not found diagnostic. -- When spawnhelper is not found the error is now catched before the CreateProcess call so the added diagnostic in bb2d11c (which was not helpful because the value for spawnhelper would be NULL in that case) is now no longer needed.

core: Fail loudly in case w32 spawner not found

2016-08-18T15:09:04Z

* src/w32-io.c (_gpgme_io_spawn): Show a message box in case gpgme-w32spawn.exe not found. -- Otherwise every engine call will just fail with unsupported protocol. Even in the debug output the problem was not made clear because CreateProcess will fail with error code 87 (Invalid Parameter) because spawnhelper is NULL. The helpful error message for ERROR_INVALID_PARAMETER would have been: "is 'NULL' correctly installed" As GpgME basically becomes useless on Windows without the spawnhelper we want to fail very loud in that case.

Fix typos found by codespell.

2015-12-02T10:28:07Z

-- Signed-off-by: Justus Winter

w32: Add extra diagnostic about possible missing gpgme-w32spawn.exe.

2015-10-28T15:28:48Z

* src/w32-io.c (_gpgme_io_spawn): Add a new diagnostic. Signed-off-by: Werner Koch

w32: Fix another memleak on error.

2014-04-16T08:19:54Z

* src/w32-io.c (create_reader): free CTX. -- Found by Hans-Christoph Steiner with cppcheck.

w32: Fix memleak in an error code paths.

2014-04-15T20:18:04Z

* src/w32-io.c (create_writer): Free CTX in cased of bad FD. * src/w32-util.c (_gpgme_mkstemp): Free TMPNAME in case of a failed mkstemp. -- Found by Hans-Christoph Steiner with cppcheck.

Make use of internal iospawn flags more flexible.

2014-04-10T09:39:14Z

* src/priv-io.h (IOSPAWN_FLAG_DETACHED): New. Renumber the others. * src/w32-io.c (_gpgme_io_spawn): Use DETACHED_PROCESS process only if IOSPAWN_FLAG_DETACHED is given. * src/w32-qt-io.cpp (_gpgme_io_spawn): Ditto. * src/w32-glib-io.c (_gpgme_io_spawn): Ditto. * src/assuan-support.c (my_spawn): Pass IOSPAWN_FLAG_DETACHED flags. * src/dirinfo.c (read_gpgconf_dirs): Ditto. * src/engine-gpg.c (start): Ditto. * src/engine-gpgconf.c (gpgconf_read, gpgconf_write): Ditto. * src/version.c (_gpgme_get_program_version): Ditto.

w32: Change the way the I/O threads are cleaned up.

2013-05-11T13:38:08Z

* src/w32-io.c (reader_context_s, create_reader) (writer_context_s, create_writer): Rename STOPPED to CLOSE_EV. (reader, writer): Remove setting of STOPPED. Wait for CLOSE_EV and then release the context. (destroy_reader, destroy_writer): Do not wait but set the CLOSE_EV. (kill_reader, kill_writer): Remove. (_gpgme_io_close): Add code from kill_reader and kill_writer. -- The old code was prone to deadlocks which were actually exhibited at Kleopatra startup. The new code is much more straightforward and easier to understand. The reason for the complex old code was probably due to our former idea to allow re-use of the I/O threads. However we have long given up on this.

Fix hang in socket closing.

2013-05-08T18:38:50Z

* src/w32-io.c (destroy_reader): Call shutdown. (reader): Do not print an error in the shutdown case.

Improve debug output of the I/O reader and writer.

2013-05-08T17:10:41Z

* src/w32-io.c (reader, writer): Also print file_sock.