gpgme/src/w32-io.c, branch gpgme-1.11.1

core, w32: Fix flags passing to gpgme-w32-spawn

2018-02-09T15:11:03Z

* src/w32-io.c (_gpgme_io_spawn): Don't hardcode flags value. -- IOSPAWN_FLAG_ALLOW_SET_FG is 2 and was translated to 1. This might fix the pinentry foreground handling pass through.

core: Replace all calls to sprintf by gpgrt_sprintf.

2017-02-02T11:35:59Z

* configure.ac (vasprintf): Remove check. * src/vasprintf.c: Remove file. * src/util.h (vasprintf, asprintf): Remove prototypes. Replace all calls to vasprintf and asprintf by gpgrt_vasprintf or gpgrt_asprintf. Also take care to use gpgrt_free on the returned value. * src/w32-util.c (_gpgme_get_gpgconf_path): Replace a gpgrt_asprintf by _gpgme_strconcat. (snprintf): New macro to use gpgrt_snprintf instead of the system's standard snprintf. Signed-off-by: Werner Koch

w32: Fix closing file descriptors.

2017-01-23T14:08:23Z

* src/w32-io.c (writer): Only stop once the buffer is drained. (destroy_writer): Wait for the writers buffer to be drained. This aligns '_gpgme_io_close's behavior with close(2) and fclose(3). GnuPG-bug-id: 2881 Signed-off-by: Justus Winter

w32: Better protect the IO-system's fd_table

2016-11-09T07:34:15Z

* src/w32-io.c (fd_table_lock): New. (new_fd): Lock allocation of a new slot. (release_fd): Lock deallocation of a slot. -- Note that we lock only the allocation but not the sanitiy checks we do further down in the code. Signed-off-by: Werner Koch

core: Remove (now) useless diagnostic

2016-08-18T15:14:36Z

* src/w32-io.c(_gpgme_io_spawn): Remove spawnhelper not found diagnostic. -- When spawnhelper is not found the error is now catched before the CreateProcess call so the added diagnostic in bb2d11c (which was not helpful because the value for spawnhelper would be NULL in that case) is now no longer needed.

core: Fail loudly in case w32 spawner not found

2016-08-18T15:09:04Z

* src/w32-io.c (_gpgme_io_spawn): Show a message box in case gpgme-w32spawn.exe not found. -- Otherwise every engine call will just fail with unsupported protocol. Even in the debug output the problem was not made clear because CreateProcess will fail with error code 87 (Invalid Parameter) because spawnhelper is NULL. The helpful error message for ERROR_INVALID_PARAMETER would have been: "is 'NULL' correctly installed" As GpgME basically becomes useless on Windows without the spawnhelper we want to fail very loud in that case.

Fix typos found by codespell.

2015-12-02T10:28:07Z

-- Signed-off-by: Justus Winter

w32: Add extra diagnostic about possible missing gpgme-w32spawn.exe.

2015-10-28T15:28:48Z

* src/w32-io.c (_gpgme_io_spawn): Add a new diagnostic. Signed-off-by: Werner Koch

w32: Fix another memleak on error.

2014-04-16T08:19:54Z

* src/w32-io.c (create_reader): free CTX. -- Found by Hans-Christoph Steiner with cppcheck.

w32: Fix memleak in an error code paths.

2014-04-15T20:18:04Z

* src/w32-io.c (create_writer): Free CTX in cased of bad FD. * src/w32-util.c (_gpgme_mkstemp): Free TMPNAME in case of a failed mkstemp. -- Found by Hans-Christoph Steiner with cppcheck.