gpgme/src/verify.c, branch gpgme-2.2.0

Fix handling of missing timestamp in SIGINFO status

2026-08-05T10:17:31Z

* src/verify.c (parse_sig_info): Add argument protocol. Check for "-" if protocol is CMS. (_gpgme_verify_status_handler): Pass protocol to parse_sig_info. * tests/gpg/t-verify.c (check_result): Add argument timestamp. Check timestamp. (main): Add expected timestamp to all check_result calls. * tests/gpgsm/t-verify.c (check_result): Add argument timestamp. Check timestamp. (main): Add expected timestamp to all check_result calls. -- S/MIME signatures do not necessarily have a timestamp. In this case gpgsm emits "-" in the SIGINFO status line. Fixes-commit: 31eb884e8f102ed3cf1220ccdd77e6e1931a9a7b GnuPG-bug-id: 8368

Provide serial number and issuer of unknown S/MIME signing certificates

2026-08-03T13:55:35Z

* src/gpgme.h.in (_gpgme_signature): Add fields issuer_serial and issuer_name. * src/verify.c (release_op_data): Free new fields. (parse_no_pubkey): New. (_gpgme_verify_status_handler): Handle NO_PUBKEY status code. * tests/run-verify.c (print_result): Print issuer_serial and issuer_name. -- GnuPG-bug-id: 8369

Handle new SIGINFO status line

2026-07-30T13:35:44Z

* src/gpgme.h.in (gpgme_status_code_t): Add status code for SIGINFO. * src/status-table.c (status_table): Add "SIGINFO". * src/verify.c (parse_sig_info): New. (_gpgme_verify_status_handler): Handle SIGINFO status line. -- GnuPG-bug-id: 8368

Ignore TRUST_ status lines if no NEWSIG was seen

2026-07-09T14:35:58Z

* src/verify.c (_gpgme_verify_status_handler): Don't return error if TRUST_* status line is seen before NEWSIG status line has been seen. -- Since recently, in de-vs compliance mode, gpgsm emits TRUST_ status lines during decryption if the validation of the encryption certificate fails. Consequently, it's not an error if a TRUST_ status line is seen without having seen a NEWSIG status line before. GnuPG-bug-id: 8333

Remove long deprecated functions.

2025-02-21T09:42:30Z

* src/gpgme.h.in (GPGME_EXPORT_MODE_NOUID): Remove. This was a left-over from an experiment. (gpgme_attr_t,_gpgme_attr_t) Remove. Deprecated sinze 2003. (gpgme_get_sig_ulong_attr): Ditto. (gpgme_get_sig_string_attr): Ditto. (gpgme_key_get_string_attr): Ditto. (gpgme_key_get_ulong_attr): Ditto. (gpgme_key_sig_get_string_attr): Ditto. (gpgme_key_sig_get_ulong_attr): Ditto. (gpgme_trust_item_get_string_attr): Ditto. (gpgme_trust_item_get_int_attr): Ditto. * src/gpgme.def: Remove them here too. * src/libgpgme.vers: Ditto. * src/trust-item.c: Remove corresponding implementations. * src/verify.c: Ditto. * src/key.c: Ditto.

core: Preserve more specific existing failure code

2023-11-14T12:51:24Z

* src/decrypt.c (_gpgme_decrypt_status_handler): Ignore received failure code if we already have a specific failure code. * src/encrypt.c (_gpgme_encrypt_status_handler): Ditto. * src/export.c (export_status_handler): Ditto. * src/genkey.c (genkey_status_handler): Ditto. * src/keylist.c (keylist_status_handler): Ditto. * src/keysign.c (keysign_status_handler): Ditto. * src/passwd.c (passwd_status_handler): Ditto. * src/revsig.c (revsig_status_handler): Ditto. * src/setexpire.c (setexpire_status_handler): Ditto. * src/sign.c (_gpgme_sign_status_handler): Ditto. * src/tofupolicy.c (tofu_policy_status_handler): Ditto. * src/verify.c (_gpgme_verify_status_handler): Ditto. -- Usually, a process emits at most one failure code. But some operations like the creation of an encrypted archive involve multiple chained processes, so that multiple failure codes can be received. We want to keep the first specific failure code we received. Further failure codes are only parsed if we received just an unspecific "general error" so far. GnuPG-bug-id: 6575

core: Return bad data error instead of general error on unexpected data

2023-07-28T12:18:21Z

* src/verify.c (_gpgme_verify_status_handler): Return GPG_ERR_BAD_DATA instead of GPG_ERR_GENERAL. -- This gives users trying to decrypt and/or verify for example a public key block a more useful error. GnuPG-bug-id: 6617

core: Support usage of gpgtar for verifying a signed archive

2023-01-25T10:26:34Z

* src/gpgme.h.in (gpgme_verify_flags_t): New enum. (GPGME_VERIFY_ARCHIVE): New const. (gpgme_op_verify_ext_start): New func. (gpgme_op_verify_ext): New func. * src/gpgme.def, src/libgpgme.vers: Add new functions. * src/verify.c (gpgme_op_verify_ext_start): New. (gpgme_op_verify_ext): New. (verify_start): Add arg FLAGS. Pass the flags to _gpgme_engine_op_verify. (gpgme_op_verify_start): Call gpgme_op_verify_ext_start with 0 for FLAGS. (gpgme_op_verify): Call gpgme_op_verify_ext with 0 for FLAGS. * src/engine.c, src/engine.h (_gpgme_engine_op_verify): Add arg FLAGS. * src/engine-backend.h (struct engine_ops): Add FLAGS to 'verify'. * src/engine-gpg.c (gpg_verify): Add arg FLAGS. Set use_gpgtar engine flag if GPGME_VERIFY_ARCHIVE flag is set. Check for new enough gpg. Use add_gpg_arg for gpg-only options without a value. Set extra options for gpgtar and pass input data to stdin when using gpgtar. * src/engine-gpgsm.c (gpgsm_verify): Add arg FLAGS. Return error if GPGME_VERIFY_ARCHIVE flag is set. * src/engine-uiserver.c (uiserver_verify): Ditto. * tests/run-verify.c (show_usage): New options --archive, --directory, and --diagnostics. (main): Parse new options. Verify and extract with gpgtar if --archive is given. Set file name of output data to value of --directory option. Print stderr of gpg/gpgtar if --diagnostics is given. -- GnuPG-bug-id: 6342

core: Fix setting of the chain_model signature result.

2020-06-05T12:46:56Z

* src/verify.c (parse_trust): Fix detection of "chain" keyword. -- Fixes-commit: da6f3dc0c53f11f7432b3c258702db07d6c37f9a from 2007 shortly after introducing this. I doubt that this info has ever been used (it is for qualified signatures, which are only supported using the legacy German RegTP rules for them which were soon overturned by the commercial CAs). Signed-off-by: Werner Koch

core: Fix format string errors in trace macros

2018-11-16T15:57:09Z

-- Signed-off-by: Werner Koch