gpgme/src/engine-uiserver.c, branch ben/gpygmeGnuPG Made Easy.http://git.bktus.com/gpgfrontend/gpgme/atom?h=ben%2Fgpygme2014-07-30T09:04:55ZFix possible realloc overflow for gpgsm and uiserver engines.2014-07-30T09:04:55ZWerner Kochwk@gnupg.org2014-07-30T09:04:55Zurn:sha1:2cbd76f7911fc215845e89b50d6af5ff4a83dd77
* src/engine-gpgsm.c (status_handler):
* src/engine-uiserver.c (status_handler):
--
After a realloc (realloc is also used for initial alloc) the allocated
size if the buffer is not correctly recorded. Thus an overflow can be
introduced by receiving data with different line lengths in a specific
order. This is not easy exploitable because libassuan constructs the
line. However a crash has been reported and thus it might be possible
to constructs an exploit.
CVE-id: CVE-2014-3564
Reported-by: Tomáš Trnka
Add GPGME_PROTOCOL_SPAWN and gpgme_op_spawn.2014-04-10T11:01:00ZWerner Kochwk@gnupg.org2014-04-10T11:01:00Zurn:sha1:4f2d652e60700e03809307a10015ff9003ac3579
* src/gpgme.h.in (GPGME_PROTOCOL_SPAWN): New.
(GPGME_SPAWN_DETACHED, GPGME_SPAWN_ALLOW_SET_FG): New.
* src/gpgme.c (gpgme_set_protocol): Add new protocol.
(gpgme_get_protocol_name): Ditto.
* src/spawn.c: New.
* src/libgpgme.vers, src/gpgme.def: Add new public functions.
* src/engine-spawn.c: New.
* src/Makefile.am: Add new files.
* src/engine-backend.h (struct engine_ops): Add OPSPAWN.
* src/engine.c (engine_ops): Add _gpgme_engine_ops_spawn.
(gpgme_get_engine_info): Add Spawn to the list of protocols.
(_gpgme_engine_op_spawn): New.
* src/gpgme-tool.c (gt_protocol_from_name): Add new protocol.
(gt_spawn, cmd_spawn): New.
Prefer GnuPG-2 engines over GnuPG-1.2013-08-02T13:25:23ZWerner Kochwk@gnupg.org2013-08-02T13:25:23Zurn:sha1:a4c80126ae4754c8478c69a8a24a6ffd975485fc
* src/util.h: Move some prototypes to ...
* src/sys-util.h: New.
* src/Makefile.am (main_sources): Add sys-util.h.
* configure.ac (AH_VERBATIM): Add DIRSEP_C and DIRSEP_S.
* src/dirinfo.c: Include sys-util.h.
(WANT_GPG_NAME, WANT_GPGSM_NAME, WANT_G13_NAME)
(WANT_UISRV_SOCKET): New.
(dirinfo): Add corresponding fields.
(parse_output): Add arg COMPONENTS and set new fields.
(read_gpgconf_dirs): Add arg components and act upon it.
(get_gpgconf_item): Call read_gpgconf_dirs two times. Add debug
output.
(_gpgme_get_default_gpg_name): New.
(_gpgme_get_default_gpgsm_name): New.
(_gpgme_get_default_g13_name): New.
(_gpgme_get_default_gpgconf_name): New.
(_gpgme_get_default_uisrv_socket): New.
* src/engine-gpg.c, src/engine-g13.c, src/engine-gpgconf.c
* src/engine-gpgsm.c, src/engine-uiserver.c: Change to use
_gpgme_get_default_ instead of those from sys-util.h.
* src/posix-util.c (_gpgme_get_gpg_path): Include sys-util.h.
(_gpgme_get_uiserver_socket_path): Remove.
* src/w32-util.c (_gpgme_get_gpg_path): Include sys-util.h.
(_gpgme_get_uiserver_socket_path): Remove.
--
The default engines names are now taken from the output of gpgconf.
If gpgconf is not installed gpg 1 is assumed and locate the same was
as gpgconf.
Make definition of off_t robust against misbehaving w32 toolchains.2013-05-16T15:48:50ZWerner Kochwk@gnupg.org2013-04-25T11:00:16Zurn:sha1:6d0d8e7ba0bb989c251545fa8af35b97d1a703ba
* configure.ac (NEED__FILE_OFFSET_BITS): Change to define gpgme_off_t
and gpgme_ssize_t.
(API__OFF_T, API__SSIZE_T): New ac_subst.
* src/gpgme.h.in: Replace all ssize_t and off_t by ac_subst macros.
* src/assuan-support.c, src/ath-pthread.c, src/ath.c, src/ath.h
* src/data-compat.c, src/data-fd.c, src/data-mem.c, src/data-stream.c
* src/data-user.c, src/data.c, src/data.h, src/engine-gpgsm.c
* src/engine-uiserver.c, src/gpgme-tool.c, src/gpgme.c: Replace off_t
by gpgme_off_t and sszie_t by gpgme_ssize_t.
* src/ath-pthread.c, src/ath.h: Include gpgme.h.
--
For a detailed description, see the gpgme.texi diff.
Enable FD passing and thus building of the UI-server.2013-02-26T16:26:44ZWerner Kochwk@gnupg.org2013-02-26T16:25:20Zurn:sha1:5090f6f246bfad2eb80f3cc222963f73996d8028
* configure.ac: Make --enable-fd-passing the default.
* src/engine-uiserver.c (_gpgme_engine_ops_uiserver): Syntax fix.
Add public function gpgme_set_pinentry_mode.2013-02-07T19:59:16ZWerner Kochwk@gnupg.org2013-02-07T19:59:16Zurn:sha1:61a0d92b679f248505f1bf16386bc41a5bf2ba1d
* src/gpgme.c (gpgme_set_pinentry_mode): New.
* src/gpgme.h.in (gpgme_pinentry_t): New.
(gpgme_set_pinentry_mode): New.
* src/context.h (struct gpgme_context): Add field pinentry_mode.
* src/engine-backend.h (struct engine_ops): Add field
set_pinentry_mode.
* src/engine-gpg.c (struct engine_gpg): Add field pinentry_mode.
(build_argv): Implement pinentry_mode.
(gpg_set_pinentry_mode): New.
(_gpgme_engine_ops_gpg): Register gpg_set_pinentry_mode.
--
Note that this new fucntion may only be used with gpg 2.1.
Use gpg_error_from_syserror instead of directly accessing errno.2013-02-06T16:35:40ZWerner Kochwk@gnupg.org2013-02-06T16:35:40Zurn:sha1:51fd6d8292cb41d743407e6ac9d86a5ab8e68d8c
--
Also fixed a couple of minor thing; e.g. save the error before calling
cleanup functions. Do not save the errno if only free is called
in between.
Do not include the removed file status-table.h2012-07-13T12:00:22ZWerner Kochwk@gnupg.org2012-07-13T12:00:22Zurn:sha1:e7aeaebb01395b170c91f290bf3ff5021023420f
* src/engine-uiserver.c: Remove status-table.h which is not anymore
built. Fixes bug#1412.
--
The file was actually removed from the code by 885243e0 but for
unknown reasons the missing file was not reported by "make distcheck".
Rework status table to be less dynamically generated.2012-02-14T12:34:44ZMarcus Brinkmannmarcus.brinkmann@ruhr-uni-bochum.de2012-02-14T12:03:46Zurn:sha1:885243e05467e79e2375b3febe7904053ab45dfc
* src/Makefile.am (EXTRA_DIST): Remove mkstatus.
(BUILT_SOURCE, MOSTLYCLEANFILES): Remove.
(main_sources): Remove status-table.h, extra-stati.h.
Add status-table.c.
(status-table.h): Remove rules for built source.
* src/decrypt.c: Don't include extra-stati.h.
* src/engine-gpg.c: Don't include status-table.h.
(status_cmp): Remove function.
(read_status): Use _gpgme_parse_status.
* src/engine-gpgsm.c: Don't include status-table.h.
(status_cmp, parse_status): Remove function.
(gpgsm_assuan_simple_command, status_handler): Use _gpgme_parse_status.
* src/engine-uiserver.c: Don't include status-table.h.
(status_cmp, parse_status): Remove function.
(uiserver_assuan_simple_command, status_handler): Use
_gpgme_parse_status.
* src/gpgme.h.in (gpgme_status_code_t): Add
GPGME_STATUS_DECRYPTION_INFO.
* src/util.h (_gpgme_status_init,_gpgme_parse_status): New declaration.
* src/status-table.c: New file.
* src/extra-stati.h, src/mkstatus: Files removed.
* version.c (do_subsystem_inits): Call _gpgme_status_init.
More include guards.2010-11-03T09:56:27ZWerner Kochwk@gnupg.org2010-11-03T09:56:27Zurn:sha1:21eb91ae3a8578b678d71083f4513de67b2e4e0f
Provide access for Wince.
Install dummy sehmap.h