gpgme/src/engine-spawn.c, branch gpgme-1.5.1GnuPG Made Easy.http://git.bktus.com/gpgfrontend/gpgme/atom?h=gpgme-1.5.12014-05-08T18:35:57ZFix a memory access and a double slash bug.2014-05-08T18:35:57ZWerner Kochwk@gnupg.org2014-05-08T18:35:57Zurn:sha1:de4a1ea684e1591975feb801e7651309e1ee2c49
* src/engine-spawn.c (engspawn_start): Allocate space for list
terminator.
* src/posix-util.c (walk_path): Fix trailing slash detection.
--
Kudos to Valgrind for pointing out these two problems.
The first is a plain allocation bug in a code pattern I have written
thousands of times - this time it went wrong. The allocation is not
user controlled thus not directly exploitable.
The second is missed to do what it intended to do. Found due to the
access of malloced but not initialized memory. Not using calloc
again proved to be helpful to detect logical error.
Actually implement flags for gpgme_op_spawn.2014-04-10T12:17:19ZWerner Kochwk@gnupg.org2014-04-10T12:17:19Zurn:sha1:d3bd8fff863f62b6d0e228aea754efbbde861e9a
* src/spawn.c (gpgme_op_spawn_start, gpgme_op_spawn): Pass FLAGS dow
to spawn_start and add FLAGS args along the call path.
* src/engine-spawn.c (engspawn_start): Hack to automagically provide
argv[0].
Add GPGME_PROTOCOL_SPAWN and gpgme_op_spawn.2014-04-10T11:01:00ZWerner Kochwk@gnupg.org2014-04-10T11:01:00Zurn:sha1:4f2d652e60700e03809307a10015ff9003ac3579
* src/gpgme.h.in (GPGME_PROTOCOL_SPAWN): New.
(GPGME_SPAWN_DETACHED, GPGME_SPAWN_ALLOW_SET_FG): New.
* src/gpgme.c (gpgme_set_protocol): Add new protocol.
(gpgme_get_protocol_name): Ditto.
* src/spawn.c: New.
* src/libgpgme.vers, src/gpgme.def: Add new public functions.
* src/engine-spawn.c: New.
* src/Makefile.am: Add new files.
* src/engine-backend.h (struct engine_ops): Add OPSPAWN.
* src/engine.c (engine_ops): Add _gpgme_engine_ops_spawn.
(gpgme_get_engine_info): Add Spawn to the list of protocols.
(_gpgme_engine_op_spawn): New.
* src/gpgme-tool.c (gt_protocol_from_name): Add new protocol.
(gt_spawn, cmd_spawn): New.