gpgme/lang/python/src, branch dkg/fix-T4276

python: stop raising BadSignatures from decrypt(verify=True)

2019-05-03T03:28:11Z

* src/core.py (decrypt): filter out signatures with errors from the returned verify_result, but avoid raising BadSignatures * tests/t-decrypt-verify.py: ensure that only a single signature is returned when evaluating cipher-3.asc, since the other signature is unknown. -- This change preserves the invariant that decrypt() only ever returns valid signatures in the verify_result, but it avoids unnecessary errors in the face of the presence of an additional bad signature. GnuPG-bug-id: 4276 Signed-off-by: Daniel Kahn Gillmor

python: overhaul logic of Context.decrypt()

2018-12-05T10:46:10Z

* lang/python/src/core.py (Context.decrypt): simplify and clarify the logic behind handling verify=False. * lang/python/tests/t-decrypt.py: ensure that we test verify=False -- The function-internal variables were pretty unclear to the reader, and the logic caused pretty nasty breakage when verify=False. GnuPG-Bug-Id: 4271 Signed-off-by: Daniel Kahn Gillmor

python: ctx.decrypt() has problematic error handling

2018-12-05T10:46:09Z

* lang/python/src/core.py (Context.decrypt): document odd error-handling behavior as a potential problem to be addressed. Signed-off-by: Daniel Kahn Gillmor

python: Clarify the meaning of ctx.decrypt(verify=[])

2018-12-05T10:46:09Z

* lang/python/src/core.py (Context.decrypt): docstring clarification of what it means to pass an empty list to the verify argument. Signed-off-by: Daniel Kahn Gillmor

python: gpg.Context.decrypt verify_sigs and sink_result are bools

2018-12-05T10:46:09Z

Both of these function-internal variables are never used for anything other than a binary state. Implement them as the booleans they are. Otherwise, casual readers of the code might think that they're supposed to represent something other than a flag (e.g. "verify_sigs" could mean "the signatures to verify", and "sink_result" could mean "the place where we sink the result"). Signed-Off-By: Daniel Kahn Gillmor

python: clarify documentation for verify argument for Context.decrypt()

2018-12-05T10:46:09Z

It's easy to miss that verify can take a list of keys. Make it more obvious to the average python dev who reads docstrings. Signed-off-by: Daniel Kahn Gillmor

python: simplify Context.decrypt()

2018-12-05T10:46:09Z

In the course of trying to address https://dev.gnupg.org/T4271, i discovered that gpg.Context.decrypt() has a bit of superfluous code. This changeset is intended to simplify the code without making any functional changes. Signed-off-by: Daniel Kahn Gillmor

python: import type

2018-11-19T10:38:50Z

* Fixed bug T4242 and tested that dropping "Import" in favour of "import_type" does indeed work just fine. Tested-by: Ben McGinnes Signed-off-by: Ben McGinnes

python: import constant

2018-11-19T10:19:42Z

* lang/python/src/constants/__init__.py: dropped use of Import capitalisation and renamed lang/python/src/constants/import.py to lang/python/src/constants/import_type.py to address bug T4242. * lang/python/doc/src/gpgme-python-howto: minor docs updates.

Python: docs tweaks

2018-10-21T18:43:36Z

* Fixed a minor error in how the reST version of the HOWTO is generated. * Updated the help() in __init__.py with a little more detail as to why not to use the lower level functions.