gpgme/lang/cpp/src/gpgsignkeyeditinteractor.cpp, branch ikloecker/t7110-nested-bindings-packagesGnuPG Made Easy.http://git.bktus.com/gpgfrontend/gpgme/atom?h=ikloecker%2Ft7110-nested-bindings-packages2024-06-11T12:23:40Zcpp: Don't include config.h2024-06-11T12:23:40ZIngo Klöckerdev@ingo-kloecker.de2024-05-27T09:44:41Zurn:sha1:e64dd7ee510cfd41cefc1ff3c6204ebe0fe1f567
* lang/cpp/src/*.cpp, lang/cpp/tests/*.cpp: Remove config.h include.
--
The C++ binding sources don't need anything from config.h.
GnuPG-bug-id: 7110
cpp: Handle statuses that need no response in the base edit interactor2022-12-08T14:31:21ZIngo Klöckerdev@ingo-kloecker.de2022-12-08T14:20:14Zurn:sha1:c419376b85ff4a489f3bf7ad97ed656495792523
* lang/cpp/src/editinteractor.cpp (edit_interactor_callback_impl): Do
not call nextState() if status needs no response.
* lang/cpp/src/gpgaddexistingsubkeyeditinteractor.cpp
(GpgAddExistingSubkeyEditInteractor::Private::nextState),
lang/cpp/src/gpgadduserideditinteractor.cpp
(GpgAddUserIDEditInteractor::nextState),
lang/cpp/src/gpggencardkeyinteractor.cpp
(GpgGenCardKeyInteractor::nextState),
lang/cpp/src/gpgrevokekeyeditinteractor.cpp
(GpgRevokeKeyEditInteractor::Private::nextState),
lang/cpp/src/gpgsetexpirytimeeditinteractor.cpp
(GpgSetExpiryTimeEditInteractor::nextState),
lang/cpp/src/gpgsetownertrusteditinteractor.cpp
(GpgSetOwnerTrustEditInteractor::nextState),
lang/cpp/src/gpgsignkeyeditinteractor.cpp
(GpgSignKeyEditInteractor::nextState): Remove handling of statuses that
need no response.
--
This change removes superfluous code duplication.
GnuPG-bug-id: 6305
cpp: Reject signing expired keys2022-09-14T08:41:38ZIngo Klöckerdev@ingo-kloecker.de2022-09-14T08:41:38Zurn:sha1:eedaaf70167f5dd7d8438235139b57527d3a961b
* lang/cpp/src/gpgsignkeyeditinteractor.cpp (enum SignKeyState): Add
new state REJECT_SIGN_EXPIRED.
(makeTable): Add entries for new state to transition map.
(GpgSignKeyEditInteractor::action): Handle new state.
--
With this change the edit interactor aborts the key signing operation
with a "key expired" error instead of with a "general error".
GnuPG-bug-id: 6155
cpp: Add support for trust signatures to sign key edit interactor2021-05-05T17:26:03ZIngo Klöckerdev@ingo-kloecker.de2021-05-05T16:30:34Zurn:sha1:a8d7b9d16796efd6f21abaeb43ccaeb2388eb6e4
* lang/cpp/src/gpgsignkeyeditinteractor.h,
lang/cpp/src/gpgsignkeyeditinteractor.cpp
(GpgSignKeyEditInteractor::setTrustSignatureTrust): New.
(GpgSignKeyEditInteractor::setTrustSignatureDepth): New.
(GpgSignKeyEditInteractor::setTrustSignatureScope): New.
* lang/cpp/src/gpgsignkeyeditinteractor.cpp
(GpgSignKeyEditInteractor::Private::Private): Initialize new member.
(makeTable): Add new transition. Fix typos in existing transitions.
(GpgSignKeyEditInteractor::action): Handle SET_TRUST_VALUE,
SET_TRUST_DEPTH, and SET_TRUST_REGEXP.
--
GnuPG-bug-id: 5245, 5421
cpp, qt: Use uidhash to select uids for signing2019-12-13T17:06:00ZAndre Heineckeaheinecke@gnupg.org2019-12-13T17:06:00Zurn:sha1:194272dbc3e326cc32c1464bc6fda0c0d10b5559
* lang/cpp/src/gpgsignkeyeditinteractor.cpp (action):
Use uidhash instead of number.
(GpgSignKeyEditInteractor::setKey): New.
* lang/cpp/src/gpgsignkeyeditinteractor.h: Update accordingly.
* lang/cpp/src/key.h, lang/cpp/src/key.cpp: Wrap uidhash.
* lang/qt/src/qgpgmesignkeyjob.cpp: Set the key.
--
Using the uidhash avoids problems when the user ids
on --edit-key are different ones then the uids
captured by gpgme when listing keys. Or if
they are in a different order. This can happen
with cached keys or keys with user attributes.
cpp: Fix dupe_ok state for single uid2019-11-04T10:17:27ZAndre Heineckeaheinecke@gnupg.org2019-11-04T10:17:27Zurn:sha1:08933c183a4c299eb4696092d6d229f607fce985
* lang/cpp/src/gpgsignkeyeditinteractor.cpp (makeTable):
Add transition from command to dupe_ok
cpp: Fix adding duplicated sigs on multiple uids2019-11-01T11:02:07ZAndre Heineckeaheinecke@gnupg.org2019-11-01T11:02:07Zurn:sha1:266e05eee859b83d97079c2fbbd2f1da010fa412
* lang/cpp/src/gpgsignkeyeditinteractor.cpp: Add another
state DUPE_OK2 to allow gpg looping over all uids.
--
When duplicated signatures should be added to multiple
user ids GnuPG will ask for each uid so we have to
add a transition for that.
GnuPG-Bug-Id: T4734
cpp: Add support for multiple keysigs in edit2019-10-29T15:31:20ZAndre Heineckeaheinecke@gnupg.org2019-10-29T15:26:42Zurn:sha1:36f7f7a478228a64d3d51a4901a264c8f55f90bb
* lang/cpp/src/gpgsignkeyeditinteractor.cpp
(GpgSignKeyEditInteractor::setDupeOk): New.
(makeTable): Add new tansitions.
(SignKeyState): Add DUPE_OK Status.
(GpgSignKeyEditInteractor::action): Handle DUPE_OK.
(GpgSignKeyEditInteractor::Private::Private): Carry flag.
--
When extended-edit is enabled this can be used to answer
the "dupe_ok" query from the edit-key with yes.
This is for:
GnuPG-Bug-Id: T4734
qt,cpp: Consistently use nullptr and override2018-12-03T11:25:00ZAndre Heineckeaheinecke@intevation.de2018-12-03T11:20:33Zurn:sha1:1d31420650bfa7ca1d1503cc7431b3360e86022c
* lang/cpp/src/Makefile.am, lang/qt/src/Makefile.am (AM_CPPFLAGS):
Add suggest-override and zero-as-null-pointer-constant warnings.
* lang/cpp/src/*, lang/qt/src/*: Consistenly use nullptr and override.
--
This was especially important for the headers so that downstream
users of GpgME++ or QGpgME do not get flooded by warnings if
they have these warnings enabled.
It also improves compiler errors/warnings in case of accidental
mistakes.
cpp: Fix handling of lsig promotion2017-12-07T15:21:01ZAndre Heineckeaheinecke@intevation.de2017-12-07T15:21:01Zurn:sha1:1458adaea4acdcf7ebbead6668476fce92db5af8
* src/gpgsignkeyeditinteractor.cpp (SignKeyState): Add second
CONFIRM state.
(makeTable): Properly handle local_promote_okay.
(action): Handle CONFIRM2.
--
This fixes changing a local signature to a "public" signature.
GnuPG-Bug-Id: T1649