gpgme/lang/cpp/src/editinteractor.cpp, branch ikloecker/t7110-nested-bindings-packagesGnuPG Made Easy.http://git.bktus.com/gpgfrontend/gpgme/atom?h=ikloecker%2Ft7110-nested-bindings-packages2024-06-11T12:23:40Zcpp: Don't include config.h2024-06-11T12:23:40ZIngo Klöckerdev@ingo-kloecker.de2024-05-27T09:44:41Zurn:sha1:e64dd7ee510cfd41cefc1ff3c6204ebe0fe1f567
* lang/cpp/src/*.cpp, lang/cpp/tests/*.cpp: Remove config.h include.
--
The C++ binding sources don't need anything from config.h.
GnuPG-bug-id: 7110
cpp: Handle smart card op failure status messages2024-04-05T13:08:01ZIngo Klöckerdev@ingo-kloecker.de2024-04-05T13:08:01Zurn:sha1:e4a95746ada20d41161c3cdfb36d5167e2712098
* lang/cpp/src/editinteractor.cpp (parse_sc_op_failure): New.
(CallbackHelper::edit_interactor_callback_impl): Parse failure code on
GPGME_STATUS_SC_OP_FAILURE status.
(sc_op_failure_to_error): New.
--
This converts a SC_OP_FAILURE status message logged by gpg to a
corresponding error. Unfortunately, GPG_ERR_BAD_PIN and
GPG_ERR_BAD_RESET_CODE are mapped to the same SC_OP_FAILURE code, so
that we had to choose one.
GnuPG-bug-id: 6971
cpp: Handle status errors in the base edit interactor2022-12-08T14:31:37ZIngo Klöckerdev@ingo-kloecker.de2022-12-08T14:27:22Zurn:sha1:e7953dcf1376631719c73d9fa34bcb96752d3794
* lang/cpp/src/editinteractor.cpp (edit_interactor_callback_impl):
Handle status errors.
* lang/cpp/src/gpgrevokekeyeditinteractor.cpp
(GpgRevokeKeyEditInteractor::Private::nextState): Remove handling of
status errors.
--
With this change status errors are handled for all interactors. In
particular, this makes all edit interactors handle canceled password
prompts correctly.
GnuPG-bug-id: 6305
cpp: Handle statuses that need no response in the base edit interactor2022-12-08T14:31:21ZIngo Klöckerdev@ingo-kloecker.de2022-12-08T14:20:14Zurn:sha1:c419376b85ff4a489f3bf7ad97ed656495792523
* lang/cpp/src/editinteractor.cpp (edit_interactor_callback_impl): Do
not call nextState() if status needs no response.
* lang/cpp/src/gpgaddexistingsubkeyeditinteractor.cpp
(GpgAddExistingSubkeyEditInteractor::Private::nextState),
lang/cpp/src/gpgadduserideditinteractor.cpp
(GpgAddUserIDEditInteractor::nextState),
lang/cpp/src/gpggencardkeyinteractor.cpp
(GpgGenCardKeyInteractor::nextState),
lang/cpp/src/gpgrevokekeyeditinteractor.cpp
(GpgRevokeKeyEditInteractor::Private::nextState),
lang/cpp/src/gpgsetexpirytimeeditinteractor.cpp
(GpgSetExpiryTimeEditInteractor::nextState),
lang/cpp/src/gpgsetownertrusteditinteractor.cpp
(GpgSetOwnerTrustEditInteractor::nextState),
lang/cpp/src/gpgsignkeyeditinteractor.cpp
(GpgSignKeyEditInteractor::nextState): Remove handling of statuses that
need no response.
--
This change removes superfluous code duplication.
GnuPG-bug-id: 6305
cpp: Handle canceling of an edit operation2022-04-05T08:17:39ZIngo Klöckerdev@ingo-kloecker.de2022-04-04T11:25:30Zurn:sha1:28cdbfdccb347e1ef15f794d4afd36f9275f073c
* lang/cpp/src/editinteractor.cpp
(CallbackHelper::edit_interactor_callback_impl): Check for error _or_
canceled state.
--
Without this canceling an edit operation resulted in a "General error".
GnuPG-bug-id: 5904
cpp: Return actual error if revocation fails2022-04-05T08:15:07ZIngo Klöckerdev@ingo-kloecker.de2022-04-04T11:15:37Zurn:sha1:db532eca8ebd64536985e7a40af22e803e3b3df9
* lang/cpp/src/editinteractor.cpp, lang/cpp/src/editinteractor.h
(EditInteractor::parseStatusError): New.
* lang/cpp/src/gpgrevokekeyeditinteractor.cpp
(GpgRevokeKeyEditInteractor::Private::nextState): Handle status
error.
--
With this change the interactor returns a proper error like "Bad
Passphrase" or "Empty Passphrase" instead of an unspecific "General
Error" if a status error occurred.
GnuPG-bug-id: 5904
cpp: Do not close stdout/stderr when destroying EditInteractor2021-05-06T08:14:44ZIngo Klöckerdev@ingo-kloecker.de2021-05-05T16:52:18Zurn:sha1:58a217b108e4c4c92306542bf9f2995254809ffb
* lang/cpp/src/editinteractor.cpp (EditInteractor::Private): Initialize
members 'state' and 'debug' in-class. Add member 'debugNeedsClosing'.
(EditInteractor::Private::Private): Remove members initializers.
Remember if 'debug' needs to be closed.
(EditInteractor::Private::~Private): Only close 'debug' if it needs to
be closed.
--
This fixes the problem that after destroying an edit interactor all
debug output went to /dev/null instead of stderr (or stdout) if one
enabled debugging of the edit interactors with GPGMEPP_INTERACTOR_DEBUG
set to stderr (or stdout).
cpp: Use cstdlib getenv for portability2020-08-06T07:50:16ZAndre Heineckeaheinecke@gnupg.org2020-08-06T07:50:16Zurn:sha1:0676d41ef57db4da469aa9b733f8965606b667ec
* lang/cpp/src/editinteractor.cpp (EditInteractor::Private::Private):
Use std::getenv.
--
This should fix compiling on MacOS X
GnuPG-Bug-Id: T5013
cpp: Add env var to control editinteractor debug2019-11-01T11:00:18ZAndre Heineckeaheinecke@gnupg.org2019-11-01T11:00:18Zurn:sha1:a4d5394b4607382d846e8c156439ac182f9945d7
* lang/cpp/src/editinteractor.cpp (EditInteractor::Private::Private):
Read "GPGMEPP_INTERACTOR_DEBUG" env var.
(EditInteractor::Private::~Private): Close debug file.
--
While it was possible for the application to control the
debug through setDebugChannel it is often times helpful
to just debug without changing the application using
GPGME
qt,cpp: Consistently use nullptr and override2018-12-03T11:25:00ZAndre Heineckeaheinecke@intevation.de2018-12-03T11:20:33Zurn:sha1:1d31420650bfa7ca1d1503cc7431b3360e86022c
* lang/cpp/src/Makefile.am, lang/qt/src/Makefile.am (AM_CPPFLAGS):
Add suggest-override and zero-as-null-pointer-constant warnings.
* lang/cpp/src/*, lang/qt/src/*: Consistenly use nullptr and override.
--
This was especially important for the headers so that downstream
users of GpgME++ or QGpgME do not get flooded by warnings if
they have these warnings enabled.
It also improves compiler errors/warnings in case of accidental
mistakes.