gpgme, branch dkg/fix-T4276

python: stop raising BadSignatures from decrypt(verify=True)

2019-05-03T03:28:11Z

* src/core.py (decrypt): filter out signatures with errors from the returned verify_result, but avoid raising BadSignatures * tests/t-decrypt-verify.py: ensure that only a single signature is returned when evaluating cipher-3.asc, since the other signature is unknown. -- This change preserves the invariant that decrypt() only ever returns valid signatures in the verify_result, but it avoids unnecessary errors in the face of the presence of an additional bad signature. GnuPG-bug-id: 4276 Signed-off-by: Daniel Kahn Gillmor

python/tests: try to decrypt and verify new test data

2019-05-03T02:23:28Z

* lang/python/tests/t-decrypt.py: test decryption of cipher-3.asc and cipher-no-sig.asc * lang/python/tests/t-decrypt-verify.py: test decryption and verification of cipher-3.asc and cipher-no-sig.asc -- note that this introduces a failed test -- decrypt-verify.py misbehaves on cipher-3.asc by throwing a BadSignature even though GnuPG-bug-id: 4276 Signed-off-by: Daniel Kahn Gillmor

tests: add two new types of encrypted data

2019-05-03T02:23:28Z

* tests/gpg/cipher-3.asc: add an encrypted file containing signatures (one from a known key, and one from an unknown key) * tests/gpg/cipher-no-sig.asc: add an encrypted file containing no signatures at all -- We currently aren't using these files yet, but they should be useful for exercising the library in unusual circumstances (where the bugs are). Signed-off-by: Daniel Kahn Gillmor

python: make it easier to run a limited number of tests

2019-05-03T02:23:28Z

* lang/python/tests/Makefile.am: prefer py_tests from the environment if present. -- I'm trying to make it nicer/quicker to hack on the testsuite for python bindings. With this change, if you're improving the python bindings test suite, you can selectively run only a few specific tests like so: lang/python$ make check py_tests='t-decrypt.py t-decrypt-verify.py' Signed-off-by: Daniel Kahn Gillmor

tests: Add cms mode to run-import

2019-05-02T08:26:44Z

* tests/run-import.c (show_usage): Add doc for cms / openpgp. (main): Handle protocol.

cpp: Add wrapper for gpgme_set_global_flag

2019-04-24T10:36:14Z

* lang/cpp/src/context.cpp (setGlobalFlag): New. * lang/cpp/src/global.h (setGlobalFlag): Export it. -- GnuPG-Bug-Id: T4471

core: Fix duplication of close_notify_handler for gpgsm.

2019-04-19T05:54:52Z

* src/engine-gpgsm.c [!USE_DESCRIPTOR_PASSING] (gpgsm_new): Remove last call to _gpgme_io_set_close_notify. -- It is called just after the code in question for all cases. GnuPG-bug-id: 4456 Fixes-commit: dd21ec997cf4b6ba18538c63c728478110ad1f60 Signed-off-by: NIIBE Yutaka

core: Fix error return.

2019-04-19T02:34:12Z

* src/engine.c (_gpgme_set_engine_info): Add error return. Signed-off-by: NIIBE Yutaka

core,w32: Fix minor potential memleak

2019-04-09T12:24:17Z

* src/w32-util.c (_gpgme_create_process_utf8): Free converted startup info strings.

core,w32: Fix new w32-util functions

2019-04-09T12:11:21Z

* src/w32-util.c (_gpgme_access): Respect mode parameter. (_gpgme_create_process_utf8): Convert startupinfo, too. -- This both did not show up in testing as we only use mode F_OK and STARTUPINFOA is basically the same as STARTUPINFOW. Fixes commit: a82e3a0ae57a48ba173e282a050680751006c074 GnuPG-Bug-Id: T4453