gpgme, branch dkg/fix-T4271

python: overhaul logic of Context.decrypt()

2018-12-04T23:41:16Z

* lang/python/src/core.py (Context.decrypt): simplify and clarify the logic behind handling verify=False. * lang/python/tests/t-decrypt.py: ensure that we test verify=False -- The function-internal variables were pretty unclear to the reader, and the logic caused pretty nasty breakage when verify=False. GnuPG-Bug-Id: 4271 Signed-off-by: Daniel Kahn Gillmor

python: ctx.decrypt() has problematic error handling

2018-12-04T23:40:25Z

* lang/python/src/core.py (Context.decrypt): document odd error-handling behavior as a potential problem to be addressed. Signed-off-by: Daniel Kahn Gillmor

python: Clarify the meaning of ctx.decrypt(verify=[])

2018-12-04T23:40:24Z

* lang/python/src/core.py (Context.decrypt): docstring clarification of what it means to pass an empty list to the verify argument. Signed-off-by: Daniel Kahn Gillmor

python: gpg.Context.decrypt verify_sigs and sink_result are bools

2018-12-04T23:40:24Z

Both of these function-internal variables are never used for anything other than a binary state. Implement them as the booleans they are. Otherwise, casual readers of the code might think that they're supposed to represent something other than a flag (e.g. "verify_sigs" could mean "the signatures to verify", and "sink_result" could mean "the place where we sink the result"). Signed-Off-By: Daniel Kahn Gillmor

python: clarify documentation for verify argument for Context.decrypt()

2018-12-04T23:40:24Z

It's easy to miss that verify can take a list of keys. Make it more obvious to the average python dev who reads docstrings. Signed-off-by: Daniel Kahn Gillmor

python: simplify Context.decrypt()

2018-12-04T23:40:24Z

In the course of trying to address https://dev.gnupg.org/T4271, i discovered that gpg.Context.decrypt() has a bit of superfluous code. This changeset is intended to simplify the code without making any functional changes. Signed-off-by: Daniel Kahn Gillmor

python: sphinx modification

2018-12-04T22:31:10Z

* The make.bat file incorrectly triggers the trailing whitespace check in the git repo (it doesn't actually have any trailing whitespace, but triggers the error on every line). * Will need to add a script to handle future org-mode conversions of the index page anyway, so will get that script to deal with this problem too by generating the make.bat file if the platform is detected as Windows. Signed-off-by: Ben McGinnes

python: Sphinx support

2018-12-04T22:17:31Z

* Added framework from sphinx-quickstart to lang/python/doc/rst/ so that Python developers already using Sphinx can use the generated reST files with existing documentation systems. * Note that when generating source files from Org-mode, the index page will require manual intervention to match the Sphinx requirements. Signed-off-by: Ben McGinnes

Merge branch 'master' of ssh+git://playfair.gnupg.org/git/gpgme

2018-12-04T21:49:41Z

python: docs update

2018-12-04T21:42:08Z

* Expanded the section on issues with Windows installations, with greater detail of which versions of Visual Studio are needed depending on which version of CPython is to be used. * Included a recommendation which is a bit harsh without being totally prickish. * Updated all files to not link to author's key or related data in order to make them all consistent with the changes in commit 649b19688132dd315e361c0f5b63ba6d8f45996d. Signed-off-by: Ben McGinnes