gpgme, branch dkg/fix-4820

gpg: Send --with-keygrip when listing keys

2020-01-23T22:57:54Z

* src/engine-gpg.c (gpg_keylist_build_options): Always pass --with-keygrip when listing keys. -- Some older versions of GnuPG (at least gpg in version 2.2.12-1+deb10u1) appear to unilaterally emit the keygrip, and it's certainly useful to know that programmatically it will always be present in the output needed. However, as of GnuPG 2.2.19-1, the following command does not emit the keygrip for non-secret keys: gpg --with-colons --with-secret --list-keys This change fixes tests/json/t-json by making the output comply with tests/json/t-keylist-secret.out.json correctly. Signed-off-by: Daniel Kahn Gillmor GnuPG-Bug-Id: 4820

tests/json: Bravo key does not have secret key material

2020-01-23T22:57:20Z

* tests/json/t-keylist-secret.out.json: indicate correctly that the "Bravo" test key does not have secret key material. -- Some older versions of GnuPG are buggy, and will claim "secret: true" for this key, even though the keyring in question has no secret key material for it. The underlying call to gpg looks something like: gpg --with-colons --with-secret --list-keys -- \ alpha@example.net bravo@example.net You can see the change in field 15 of the "pub" and "sub" output. Signed-off-by: Daniel Kahn Gillmor GnuPG-Bug-Id: 4820

core: Add MacOS fallbacks to look for binaries

2020-01-17T11:42:56Z

* src/posix-util.c (find_executable): New. (walk_path_str): Factored out from walk_path. (walk_path): Replaced by find_executable. (_gpgme_get_gpg_path, _gpgme_get_gpgconf_path): Use find_executable. -- This should help to locate GnuPG on MacOS systems where it is not part of the PATH environment variable and should reduce the need to have fixed path known at GPGME compile time. mailvelope/issue699

cpp, qt: Use uidhash to select uids for signing

2019-12-13T17:06:00Z

* lang/cpp/src/gpgsignkeyeditinteractor.cpp (action): Use uidhash instead of number. (GpgSignKeyEditInteractor::setKey): New. * lang/cpp/src/gpgsignkeyeditinteractor.h: Update accordingly. * lang/cpp/src/key.h, lang/cpp/src/key.cpp: Wrap uidhash. * lang/qt/src/qgpgmesignkeyjob.cpp: Set the key. -- Using the uidhash avoids problems when the user ids on --edit-key are different ones then the uids captured by gpgme when listing keys. Or if they are in a different order. This can happen with cached keys or keys with user attributes.

core: Extend gpgme_user_id_t with uidhash member.

2019-12-13T14:11:00Z

* src/gpgme.h.in (struct _gpgme_user_id): Add field 'uidhash'. * src/key.c (gpgme_key_unref): Free it. * src/keylist.c (keylist_colon_handler): Set it. * tests/run-keylist.c (main): Print it. -- The uidhash value is part of gpg's output since the year 2005. This now adds support to gpgme. The application for uidhash is to select a user id in an edit interactor: Instead of giving the number of the user id, the uidhash value can be be used to avoid tracking the user id numbers. Signed-off-by: Werner Koch

Revert "doc: Remove UI Server documentation"

2019-12-11T09:30:41Z

This reverts commit 1b2ad3b73c37d0583b8e438b4707dca60e26ae7e. -- Just removing the documentation was not the right way as this is still in use.

gpg: Avoid error diagnostics with --override-session-key when verifying

2019-12-06T01:41:44Z

* src/engine-gpg.c (gpg_decrypt): only send --no-keyring when we are not verifying. -- Without this change, the signature verification would fail. This problem was introduced in bded8ebc59c7fdad2617f4c9232a58047656834c in an attempt to avoid an error when *not* verifying. Clearly more test suite coverage is needed to avoid introducing this sort of problem in the future. GnuPG-bug-id: 3464 Signed-off-by: Daniel Kahn Gillmor

gpgme-tool: Fix help text for INCLUDE_CERTS.

2019-12-03T23:42:07Z

* src/gpgme-tool.c (hlp_include_certs): added missing newline. Signed-off-by: Daniel Kahn Gillmor

core,w32: Silence compiler warnings.

2019-11-27T19:40:39Z

* src/w32-util.c (_gpgme_w32_cancel_synchronous_io): Add some casts. -- Signed-off-by: Werner Koch

doc: Remove UI Server documentation

2019-11-12T10:04:11Z

* doc/Makefile.am: Remove uiserver.texi * doc/gpgme.texi: Remove UI-Server mentions. * doc/uiserver.texi: Removed. -- This prepares the removal of UI Server from implementing applications like Kleopatra. The only user of the UI Server is GpgEX and even that does not need it at all and is better served with process calls. GnuPG-Bug-Id: T4030