From bd612f23607d2c4d4adbe3a3ddc28a1711f5308b Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Wed, 2 Nov 2022 10:40:24 +0100 Subject: agent: Avoid blanks in the ssh key's comment. * agent/command-ssh.c (card_key_available): Replace blanks. -- For managing the authorized_key file of ssh it is convenient if the comment does not have any spaces. Thus we now return cardno:FFFE_50FF3D01 instead of cardno:FFFE 50FF3D01 Note that gpg --export-ssh-key uses the keyid as comment because it does not known the S/N of the card. Gpg-agent however does not know about OpenPGP and uses the s/n. --- agent/command-ssh.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'agent/command-ssh.c') diff --git a/agent/command-ssh.c b/agent/command-ssh.c index 50622850c..f237f9355 100644 --- a/agent/command-ssh.c +++ b/agent/command-ssh.c @@ -2424,6 +2424,7 @@ card_key_available (ctrl_t ctrl, const struct card_key_info_s *keyinfo, if (cardsn) { char *dispsn; + char *p; /* If the card handler is able to return a short serialnumber, use that one, else use the complete serialno. */ @@ -2442,6 +2443,10 @@ card_key_available (ctrl_t ctrl, const struct card_key_info_s *keyinfo, gcry_sexp_release (s_pk); return err; } + /* Let's avoid blanks in the comment. */ + for (p=*cardsn; *p; p++) + if (spacep (p)) + *p = '_'; } xfree (pkbuf); -- cgit v1.2.3