diff options
| author | Werner Koch <[email protected]> | 2016-01-06 16:51:58 +0000 |
|---|---|---|
| committer | Werner Koch <[email protected]> | 2016-01-07 18:09:16 +0000 |
| commit | 126aebbb82667d160c8c4435898efeb3b43c4ec8 (patch) | |
| tree | 401a93cc0827aa6d8611dcd468552b9d10bbafde /sm/call-dirmngr.c | |
| parent | kbx: Avoid warnings about useless assignments. (diff) | |
| download | gnupg-126aebbb82667d160c8c4435898efeb3b43c4ec8.tar.gz gnupg-126aebbb82667d160c8c4435898efeb3b43c4ec8.zip | |
sm: Avoid warnings about useless assignments.
* sm/call-dirmngr.c (prepare_dirmngr): Remove setting of ERR.
(unhexify_fpr): Remove useless computation on N.
* sm/certchain.c (do_validate_chain): Remove clearing of RC. Remove
useless setting of RC.
* sm/fingerprint.c (gpgsm_get_keygrip): Remove setting of RC.
* sm/gpgsm.c (build_list): Replace final stpcpy by strcpy.
* sm/keydb.c (keydb_clear_some_cert_flags): Remove clearing of RC.
* sm/server.c (cmd_getauditlog): Comment unused skip_options.
Signed-off-by: Werner Koch <[email protected]>
Diffstat (limited to '')
| -rw-r--r-- | sm/call-dirmngr.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/sm/call-dirmngr.c b/sm/call-dirmngr.c index b06397f6e..379d7e9cc 100644 --- a/sm/call-dirmngr.c +++ b/sm/call-dirmngr.c @@ -181,9 +181,11 @@ prepare_dirmngr (ctrl_t ctrl, assuan_context_t ctx, gpg_error_t err) server->host, server->port, user, pass, base); line[DIM (line) - 1] = 0; - err = assuan_transact (ctx, line, NULL, NULL, NULL, NULL, NULL, NULL); - if (gpg_err_code (err) == GPG_ERR_ASS_UNKNOWN_CMD) - err = 0; /* Allow the use of old dirmngr versions. */ + assuan_transact (ctx, line, NULL, NULL, NULL, NULL, NULL, NULL); + /* The code below is not required becuase we don't return an error. */ + /* err = [above call] */ + /* if (gpg_err_code (err) == GPG_ERR_ASS_UNKNOWN_CMD) */ + /* err = 0; /\* Allow the use of old dirmngr versions. *\/ */ server = server->next; } @@ -402,7 +404,6 @@ unhexify_fpr (const char *hexstr, unsigned char *fpr) ; if (*s || (n != 40)) return 0; /* no fingerprint (invalid or wrong length). */ - n /= 2; for (s=hexstr, n=0; *s; s += 2, n++) fpr[n] = xtoi_2 (s); return 1; /* okay */ |