diff options
author | Neal H. Walfield <[email protected]> | 2015-10-18 16:44:05 +0000 |
---|---|---|
committer | Neal H. Walfield <[email protected]> | 2015-10-18 16:45:40 +0000 |
commit | f77913e0ff7be4cd9c6337a70ac715e6f4a43572 (patch) | |
tree | d54aafd73b9f88111d953413c5e0b90c67a79239 /g10/mainproc.c | |
parent | common: Prefix the mkdir functions with gnupg_. Make args const. (diff) | |
download | gnupg-f77913e0ff7be4cd9c6337a70ac715e6f4a43572.tar.gz gnupg-f77913e0ff7be4cd9c6337a70ac715e6f4a43572.zip |
g10: Add TOFU support.
* configure.ac: Check for sqlite3.
(SQLITE3_CFLAGS): AC_SUBST it.
(SQLITE3_LIBS): Likewise.
* g10/Makefile.am (AM_CFLAGS): Add $(SQLITE3_CFLAGS).
(gpg2_SOURCES): Add tofu.h and tofu.c.
(gpg2_LDADD): Add $(SQLITE3_LIBS).
* g10/tofu.c: New file.
* g10/tofu.h: New file.
* g10/options.h (trust_model): Define TM_TOFU and TM_TOFU_PGP.
(tofu_db_format): Define.
* g10/packet.h (PKT_signature): Add fields digest and digest_len.
* g10/gpg.c: Include "tofu.h".
(cmd_and_opt_values): Declare aTOFUPolicy, oTOFUDefaultPolicy,
oTOFUDBFormat.
(opts): Add them.
(parse_trust_model): Recognize the tofu and tofu+pgp trust models.
(parse_tofu_policy): New function.
(parse_tofu_db_format): New function.
(main): Initialize opt.tofu_default_policy and opt.tofu_db_format.
Handle aTOFUPolicy, oTOFUDefaultPolicy and oTOFUDBFormat.
* g10/mainproc.c (do_check_sig): If the signature is good, copy the
hash to SIG->DIGEST and set SIG->DIGEST_LEN appropriately.
* g10/trustdb.h (get_validity): Add arguments sig and may_ask. Update
callers.
(tdb_get_validity_core): Add arguments sig and may_ask. Update
callers.
* g10/trust.c (get_validity) Add arguments sig and may_ask. Pass them
to tdb_get_validity_core.
* g10/trustdb.c: Include "tofu.h".
(trust_model_string): Handle TM_TOFU and TM_TOFU_PGP.
(tdb_get_validity_core): Add arguments sig and may_ask. If
OPT.TRUST_MODEL is TM_TOFU or TM_TOFU_PGP, compute the TOFU trust
level. Combine it with the computed PGP trust level, if appropriate.
* g10/keyedit.c: Include "tofu.h".
(show_key_with_all_names_colon): If the trust mode is tofu or
tofu+pgp, then show the trust policy.
* g10/keylist.c: Include "tofu.h".
(public_key_list): Also show the PGP stats if the trust model is
TM_TOFU_PGP.
(list_keyblock_colon): If the trust mode is tofu or
tofu+pgp, then show the trust policy.
* g10/pkclist.c: Include "tofu.h".
* g10/gpgv.c (get_validity): Add arguments sig and may_ask.
(enum tofu_policy): Define.
(tofu_get_policy): New stub.
(tofu_policy_str): Likewise.
* g10/test-stubs.c (get_validity): Add arguments sig and may_ask.
(enum tofu_policy): Define.
(tofu_get_policy): New stub.
(tofu_policy_str): Likewise.
* doc/DETAILS: Describe the TOFU Policy field.
* doc/gpg.texi: Document --tofu-set-policy, --trust-model=tofu,
--trust-model=tofu+pgp, --tofu-default-policy and --tofu-db-format.
* tests/openpgp/Makefile.am (TESTS): Add tofu.test.
(TEST_FILES): Add tofu-keys.asc, tofu-keys-secret.asc,
tofu-2183839A-1.txt, tofu-BC15C85A-1.txt and tofu-EE37CF96-1.txt.
(CLEANFILES): Add tofu.db.
(clean-local): Add tofu.d.
* tests/openpgp/tofu.test: New file.
* tests/openpgp/tofu-2183839A-1.txt: New file.
* tests/openpgp/tofu-BC15C85A-1.txt: New file.
* tests/openpgp/tofu-EE37CF96-1.txt: New file.
* tests/openpgp/tofu-keys.asc: New file.
* tests/openpgp/tofu-keys-secret.asc: New file.
--
Signed-off-by: Neal H. Walfield <[email protected]>.
Diffstat (limited to 'g10/mainproc.c')
-rw-r--r-- | g10/mainproc.c | 30 |
1 files changed, 24 insertions, 6 deletions
diff --git a/g10/mainproc.c b/g10/mainproc.c index 9f02b1555..af5098717 100644 --- a/g10/mainproc.c +++ b/g10/mainproc.c @@ -851,6 +851,7 @@ do_check_sig (CTX c, kbnode_t node, int *is_selfsig, PKT_signature *sig; gcry_md_hd_t md = NULL; gcry_md_hd_t md2 = NULL; + gcry_md_hd_t md_good = NULL; int algo, rc; assert (node->pkt->pkttype == PKT_SIGNATURE); @@ -926,8 +927,21 @@ do_check_sig (CTX c, kbnode_t node, int *is_selfsig, return GPG_ERR_SIG_CLASS; rc = signature_check2 (sig, md, NULL, is_expkey, is_revkey, NULL); - if (gpg_err_code (rc) == GPG_ERR_BAD_SIGNATURE && md2) - rc = signature_check2 (sig, md2, NULL, is_expkey, is_revkey, NULL); + if (! rc) + md_good = md; + else if (gpg_err_code (rc) == GPG_ERR_BAD_SIGNATURE && md2) + { + rc = signature_check2 (sig, md2, NULL, is_expkey, is_revkey, NULL); + if (! rc) + md_good = md2; + } + + if (md_good) + { + unsigned char *buffer = gcry_md_read (md_good, 0); + sig->digest_len = gcry_md_get_algo_dlen (map_md_openpgp_to_gcry (algo)); + memcpy (sig->digest, buffer, sig->digest_len); + } gcry_md_close (md); gcry_md_close (md2); @@ -1848,9 +1862,10 @@ check_sig_and_print (CTX c, kbnode_t node) assert (pk); - /* Get it before we print anything to avoid interrupting the - output with the "please do a --check-trustdb" line. */ - valid = get_validity (pk, un->pkt->pkt.user_id); + /* Since this is just informational, don't actually ask the + user to update any trust information. (Note: we register + the signature later.) */ + valid = get_validity (pk, un->pkt->pkt.user_id, NULL, 0); keyid_str[17] = 0; /* cut off the "[uncertain]" part */ @@ -1939,8 +1954,11 @@ check_sig_and_print (CTX c, kbnode_t node) else if (un->pkt->pkt.user_id->is_expired) valid = _("expired"); else + /* Since this is just informational, don't + actually ask the user to update any trust + information. */ valid = (trust_value_to_string - (get_validity (pk, un->pkt->pkt.user_id))); + (get_validity (pk, un->pkt->pkt.user_id, sig, 0))); log_printf (" [%s]\n",valid); } else |